-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Travis tests #35014
Fix Travis tests #35014
Conversation
cc #35011 |
@vadimcn maybe better use a Also you could change this line in compile test to a |
Can't println from panic_ unwind, as it precedes std in the dependency chain. I was counting on panic! printing the line number.
In any case, I'm pretty sure it's the second return site. We're probably trying to get a stack trace through some function that llvm has decided is nounwind.
|
@vadimcn FWIW I can reproduce locally inside the docker container (Ubuntu 16.04) and it appears to be the src/test/run-pass/backtrace.rs test failing which in turn causes compiletest to fail as well. |
Mmkay... so we can fix this by reverting to |
@vadimcn looks like tests passed (yay!), wanna merge this after cleaning up a bit? |
Sure. Though this may mask bugs like this one. |
@bors: p=1 (fixing travis) |
⌛ Testing commit 5fbcf08 with merge d489cae... |
💔 Test failed - auto-linux-64-debug-opt |
@bors: retry
On Mon, Jul 25, 2016 at 1:51 PM, bors notifications@github.com wrote:
|
⌛ Testing commit 5fbcf08 with merge d1b9c92... |
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
@bors: retry force |
⌛ Testing commit 5fbcf08 with merge db3db70... |
💔 Test failed - auto-win-gnu-32-opt |
welp |
@bors: retry On Mon, Jul 25, 2016 at 2:37 PM, Steve Klabnik notifications@github.com
|
💥 Test timed out |
@bors: retry On Jul 26, 2016, 02:10 -0700, bors notifications@github.com, wrote:
|
@bors: retry force clean |
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
@bors: retry On Tue, Jul 26, 2016 at 12:55 PM, bors notifications@github.com wrote:
|
r? @vadimcn