Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis tests #35014

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Fix Travis tests #35014

merged 1 commit into from
Jul 27, 2016

Conversation

vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Jul 24, 2016

@vadimcn
Copy link
Contributor Author

vadimcn commented Jul 24, 2016

cc #35011

@TimNN
Copy link
Contributor

TimNN commented Jul 24, 2016

@vadimcn maybe better use a println! to prevent the double panic (and perhaps add some metadata, ie. the value of version, should that check fail, not sure which of the parameters are relevant)?

Also you could change this line in compile test to a println! as well to hopefully know exactly which test is failing (as long as compiletest doesn't do stuff in parallel).

@vadimcn
Copy link
Contributor Author

vadimcn commented Jul 24, 2016 via email

@alexcrichton
Copy link
Member

@vadimcn FWIW I can reproduce locally inside the docker container (Ubuntu 16.04) and it appears to be the src/test/run-pass/backtrace.rs test failing which in turn causes compiletest to fail as well.

@vadimcn
Copy link
Contributor Author

vadimcn commented Jul 25, 2016

Mmkay... so we can fix this by reverting to gcc_personality's behavior (i.e. allowing portions of code to be not covered by the unwind table).

@alexcrichton
Copy link
Member

@vadimcn looks like tests passed (yay!), wanna merge this after cleaning up a bit?

@vadimcn vadimcn changed the title Travis test - do not merge Fix Travis tests Jul 25, 2016
@vadimcn
Copy link
Contributor Author

vadimcn commented Jul 25, 2016

Sure. Though this may mask bugs like this one.
r?

@vadimcn vadimcn assigned alexcrichton and unassigned vadimcn Jul 25, 2016
@alexcrichton
Copy link
Member

Ah ok, maybe once we drop support for LLVM 3.7 we can try removing this clause?

@bors: r+ 5fbcf08

@alexcrichton
Copy link
Member

@bors: p=1

(fixing travis)

@bors
Copy link
Contributor

bors commented Jul 25, 2016

⌛ Testing commit 5fbcf08 with merge d489cae...

@bors
Copy link
Contributor

bors commented Jul 25, 2016

💔 Test failed - auto-linux-64-debug-opt

@alexcrichton
Copy link
Member

@bors: retry

  • good ol network failures

On Mon, Jul 25, 2016 at 1:51 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-debug-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-debug-opt/builds/3224


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#35014 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95DDh8zLfB6Arly5ik3myXdREtoHLks5qZSHbgaJpZM4JTp79
.

@bors
Copy link
Contributor

bors commented Jul 25, 2016

⌛ Testing commit 5fbcf08 with merge d1b9c92...

@bors
Copy link
Contributor

bors commented Jul 25, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@steveklabnik
Copy link
Member

@bors: retry force

@bors
Copy link
Contributor

bors commented Jul 25, 2016

⌛ Testing commit 5fbcf08 with merge db3db70...

@bors
Copy link
Contributor

bors commented Jul 25, 2016

💔 Test failed - auto-win-gnu-32-opt

@steveklabnik
Copy link
Member

welp

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Jul 25, 2016 at 2:37 PM, Steve Klabnik notifications@github.com
wrote:

welp


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#35014 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95M2pwTEOASX1M1kgTNz2_P2MQ0P_ks5qZSySgaJpZM4JTp79
.

@bors
Copy link
Contributor

bors commented Jul 25, 2016

⌛ Testing commit 5fbcf08 with merge 9c396d8...

bors added a commit that referenced this pull request Jul 25, 2016
@bors
Copy link
Contributor

bors commented Jul 26, 2016

💥 Test timed out

@steveklabnik
Copy link
Member

@bors: retry

On Jul 26, 2016, 02:10 -0700, bors notifications@github.com, wrote:

💥 Test timed out


You are receiving this because you commented.
Reply to this email directly, view it on GitHub (#35014 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AABsivIpbeqsClmJHvUhz8bmExIiokhCks5qZc8UgaJpZM4JTp79).

@alexcrichton
Copy link
Member

@bors: retry force clean

@bors
Copy link
Contributor

bors commented Jul 26, 2016

⌛ Testing commit 5fbcf08 with merge 0aa25b3...

bors added a commit that referenced this pull request Jul 26, 2016
@bors
Copy link
Contributor

bors commented Jul 26, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Jul 26, 2016 at 12:55 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/1981


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#35014 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95JaU6LZUVz-hV2ZLXRfrvgJ8ub9Kks5qZmYkgaJpZM4JTp79
.

@bors
Copy link
Contributor

bors commented Jul 27, 2016

⌛ Testing commit 5fbcf08 with merge b541f5f...

bors added a commit that referenced this pull request Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants