Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0229 to new format #35374

Merged
merged 2 commits into from
Aug 6, 2016
Merged

Update E0229 to new format #35374

merged 2 commits into from
Aug 6, 2016

Conversation

mrabault
Copy link

@mrabault mrabault commented Aug 5, 2016

Hello,

This fixes #35305, for #35233. I ran the tests, no unit test broke, even though some were ignored.

Cheers

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

Thanks for the PR!

Yeah, it's suspicious when none of the unit tests catch that you made the change. I talk about this a bit on my blog post

Even though there aren't any failures, you should update the unit test with the new label so it can be tested. You just need to add a NOTE <insert label> in the test, and once it sees the NOTE it'll look to make sure the other labels are checked.

You can also do a git grep E0229 to see if there are other tests that also need the label.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 5, 2016

📌 Commit 51a270f has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 5, 2016
…urner

Update E0229 to new format

Hello,

This fixes rust-lang#35305. I ran the tests, no unit test broke, even though some were ignored.

Cheers

r? @jonathandturner
bors added a commit that referenced this pull request Aug 6, 2016
eddyb added a commit to eddyb/rust that referenced this pull request Aug 6, 2016
…urner

Update E0229 to new format

Hello,

This fixes rust-lang#35305. I ran the tests, no unit test broke, even though some were ignored.

Cheers

r? @jonathandturner
bors added a commit that referenced this pull request Aug 6, 2016
@bors bors merged commit 51a270f into rust-lang:master Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E0229 needs to be updated to new format
4 participants