Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error format for E0130 #35331

Merged
merged 2 commits into from
Aug 12, 2016
Merged

Update error format for E0130 #35331

merged 2 commits into from
Aug 12, 2016

Conversation

trixnz
Copy link
Contributor

@trixnz trixnz commented Aug 4, 2016

Fixes #35256 as part of #35233

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 4, 2016

📌 Commit 625fc29 has been approved by jonathandturner

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
@sanxiyn
Copy link
Member

sanxiyn commented Aug 5, 2016

From Travis:

failures:
    [compile-fail] compile-fail/no-patterns-in-args.rs

bors added a commit that referenced this pull request Aug 5, 2016
@trixnz
Copy link
Contributor Author

trixnz commented Aug 5, 2016

@sanxiyn It should be fixed now with the addition of 4c672e0.
test result: ok. 2390 passed; 0 failed; 21 ignored; 0 measured

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 5, 2016

📌 Commit 4c672e0 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 5, 2016
bors added a commit that referenced this pull request Aug 6, 2016
@eddyb
Copy link
Member

eddyb commented Aug 6, 2016

@bors r- doesn't merge cleanly

bors added a commit that referenced this pull request Aug 6, 2016
@sophiajt
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 10, 2016

📌 Commit e2cc157 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
bors added a commit that referenced this pull request Aug 11, 2016
@bors bors merged commit e2cc157 into rust-lang:master Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants