Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Path and PathBuf docs #35786

Merged
merged 1 commit into from
Sep 1, 2016
Merged

Conversation

GuillaumeGomez
Copy link
Member

@steveklabnik
Copy link
Member

Thanks! 😄

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 18, 2016

📌 Commit d56f9ff has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 18, 2016
@GuillaumeGomez
Copy link
Member Author

Updated.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 19, 2016

📌 Commit 481b0f3 has been approved by steveklabnik

@sophiajt
Copy link
Contributor

@bors r-

From the best I can tell, this seems to fail bors. https://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/10236/steps/test/logs/stdio

@GuillaumeGomez - can you confirm that this works on the latest Rust? Some new error message went in recently that may have changed things.

@sophiajt
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 19, 2016

📌 Commit 481b0f3 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 20, 2016
eddyb added a commit to eddyb/rust that referenced this pull request Aug 22, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
@sophiajt
Copy link
Contributor

@bors r-

Looks like this might have some broken links on OS X. This is from the latest rollup:

Linkcheck stage2 (x86_64-apple-darwin)
core/result/index.html:392: broken link - core/result/struct.Result.html
core/result/struct.IntoIter.html:54: broken link - core/result/struct.Result.html
std/path/struct.Path.html:474: broken link - std/path/ffi/struct.OsStr.html
std/path/struct.Path.html:496: broken link - std/path/fmt/trait.Display.html
std/path/struct.PathBuf.html:598: broken link - std/path/ffi/struct.OsStr.html
std/path/struct.PathBuf.html:620: broken link - std/path/fmt/trait.Display.html
std/result/index.html:392: broken link - std/result/struct.Result.html
std/result/struct.IntoIter.html:54: broken link - std/result/struct.Result.html

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 25, 2016

📌 Commit a377adb has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 25, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 26, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 26, 2016
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 27, 2016
@GuillaumeGomez
Copy link
Member Author

@bors: r-

Still link failure.

@GuillaumeGomez
Copy link
Member Author

Updated links and checked manually after

make docs

All good now.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 31, 2016

📌 Commit 96e3103 has been approved by steveklabnik

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
bors added a commit that referenced this pull request Sep 1, 2016
@bors bors merged commit 96e3103 into rust-lang:master Sep 1, 2016
@GuillaumeGomez GuillaumeGomez deleted the paths_doc branch September 1, 2016 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants