Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 21 pull requests #35846

Closed
wants to merge 47 commits into from
Closed

Rollup of 21 pull requests #35846

wants to merge 47 commits into from

Conversation

matthew-piziak and others added 30 commits August 15, 2016 18:46
I've also removed the `main()` wrapper, which I believe is extraneous.
LMK if that's incorrect.
Saying that "[for-loop iteration] fails because .. has no IntoIterator
impl" is more direct than saying "...no Iterator impl" because for loops
sugar into IntoIterator invocations. It just happens that the other
Range* operators implement Iterator and rely on the fact that
`IntoIterator` is implemented for `T: Iterator`.
PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
Currently most of the operator traits use trivial implementation
examples that only perform side effects. Honestly, that might not be too
bad for the sake of documentation; but anyway, here's a proposal to move
a slightly modified version of the module-level point-addition example
into the `Add` documentation, since it's more evocative of addition
semantics.

Part of rust-lang#29365

wrap identifiers in backticks

minor rephrasing

fix module-level documentation to be more truthful

This branch changes the example for `Add` to no longer be a "minimum implementation that prints something to the screen".
Changed datastructure to data structure
* `std::ffi::OsStr::new`.
* `std::ffi::OsStr::is_empty`.
* `std::ffi::OsStr::len`.
Vector-scalar multipication is a good usecase for this. Thanks #rust!
Part of rust-lang#29365

explain that std::mem::drop in prelude will invoke Drop

change "prelude" -> "the prelude"; change links to reference-style

move link references to links' section
Instead of listing every field it will now show missing `a`, `z`, `b`, and 1 other field
rustdoc: remove the `!` from macro URLs and titles

Because the `!` is part of a macro use, not the macro's name. E.g., you write `macro_rules! foo` not `macro_rules! foo!`, also `#[macro_import(foo)]`.

(Pulled out of rust-lang#35020).
…dturner

Update the wording for E0063. This will truncate the fields to 3.

Instead of listing every field it will now show missing `a`, `z`, `b`, and 1 other field
This is for rust-lang#35218 as part of rust-lang#35233

r? @jonathandturner
…ror, r=steveklabnik

explicitly show how iterating over `..` fails

I've also removed the `main()` wrapper, which I believe is extraneous.
LMK if that's incorrect.
…=GuillaumeGomez

replace `Add` example with something more evocative of addition

Currently most of the operator traits use trivial implementation
examples that only perform side effects. Honestly, that might not be too
bad for the sake of documentation; but anyway, here's a proposal to move
a slightly modified version of the module-level point-addition example
into the `Add` documentation, since it's more evocative of addition
semantics.

Part of rust-lang#29365
Jonathan Turner added 17 commits August 19, 2016 18:50
…veklabnik

note that calling drop() explicitly is a compiler error

Part of rust-lang#29365
…tln-remaining, r=GuillaumeGomez

accumulate vector and assert for RangeFrom and RangeInclusive examples

PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
…llaumeGomez

Add a few doc examples for `std::ffi::OsStr`.
… r=jonathandturner

updated E0395 to new error format

Updated E0395 to new error format.
Part of rust-lang#35233
Fixes rust-lang#35693

Thanks again for letting me help!

r? @jonathandturner
…=jonathandturner

updated E0396 to new error format

Updated E0396 to new error format.
Part of rust-lang#35233
Fixes rust-lang#35779

Thanks again for letting me help!

r? @jonathandturner
Very minor spelling fix in the book

Changed datastructure to data structure.

r? @steveklabnik
Fix minor typo

Minor typo in the book.
…steveklabnik

demonstrate `RHS != Self` use cases for `Mul` and `Div`

Vector-scalar multipication is a good usecase for this. Thanks #rust!
…=steveklabnik

replace `AddAssign` example with something more evocative of addition

This is analogous to PR rust-lang#35709 for the `Add` trait.
…on_test, r=alexcrichton

Add workaround to detect correct compiler version

This adds a workaround which fixes a rustbuild issue where the wrong compiler is checked for the version number.  The bug would arise if you build the system correctly then changed to any other version (eg doing a `git pull`).  After changing to the new version, building would fail and complain that crates were built with the wrong compiler.

There are actually two compilers at play, the bootstrapping compiler (called the "snapshot" compiler) and the actual compiler being built (the "real" compiler).  In the case of this issue, the wrong compiler was being checked for version mismatch.

r? @alexcrichton
Update error format for E0232

Fixes rust-lang#35795, as part of rust-lang#35233.

Excited to make my first contribution to rustc!

r? @jonathandturner
…klabnik

replace `Not` example with something more evocative
…klabnik

replace `Neg` example with something more evocative of negation
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@sophiajt
Copy link
Contributor Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Aug 20, 2016

📌 Commit ce6ae56 has been approved by jonathandturner

@bors
Copy link
Contributor

bors commented Aug 20, 2016

⌛ Testing commit ce6ae56 with merge 8674766...

@bors
Copy link
Contributor

bors commented Aug 20, 2016

💔 Test failed - auto-mac-64-opt

@sophiajt sophiajt closed this Aug 20, 2016
@sophiajt sophiajt deleted the rollup branch August 20, 2016 13:15
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.