Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0503 to the new format #35817

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Update E0503 to the new format #35817

merged 1 commit into from
Aug 23, 2016

Conversation

wesleywiser
Copy link
Member

Fixes #35703
Part of #35233

r? @jonathandturner

//~^ NOTE reference must be valid for the block suffix following statement 1 at 14:30...
//~| NOTE borrow of `x` occurs here
//~| NOTE borrow of `x` occurs here
//~| NOTE borrow of `x` occurs here
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add three of these in order to get this test to pass. It looks like this note appears three times in the json output for the same span. Is that a bug?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's right. It actually shows up that many times in the test since there are multiple tests that will label that same span.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok. I noticed that this test is failing because someone else fixed
another error before I pulled. I'll fix that up tonight or tomorrow
morning.

On Fri, Aug 19, 2016, 7:01 PM Jonathan Turner notifications@github.com
wrote:

In src/test/compile-fail/regions-escape-loop-via-vec.rs
#35817 (comment):

@@ -12,10 +12,18 @@
fn broken() {
let mut x = 3;
let mut _y = vec!(&mut x);

  • //~^ NOTE reference must be valid for the block suffix following statement 1 at 14:30...
  • //~| NOTE borrow of x occurs here
  • //~| NOTE borrow of x occurs here
  • //~| NOTE borrow of x occurs here

Yup, that's right. It actually shows up that many times in the test since
there are multiple tests that will label that same span.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/rust/pull/35817/files/005a8909800597ed37163c1019ba54c5e2520466#r75563067,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyu2OzVtpqwrKFnqfHD2wQZQo4E0_DDks5qhjXYgaJpZM4JoFfF
.

@wesleywiser
Copy link
Member Author

Tests now pass

@sophiajt
Copy link
Contributor

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 22, 2016

📌 Commit 9bb8b65 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
bors added a commit that referenced this pull request Aug 22, 2016
@bors bors merged commit 9bb8b65 into rust-lang:master Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants