Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition Travis CI to use rustbuild. #36180

Merged
merged 1 commit into from
Sep 3, 2016
Merged

Transition Travis CI to use rustbuild. #36180

merged 1 commit into from
Sep 3, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv frewsxcv changed the title Transition Travis CI to use rustbuild. [TESTING, DON'T REVIEW] Transition Travis CI to use rustbuild. [WIP] Sep 1, 2016
@sanxiyn
Copy link
Member

sanxiyn commented Sep 1, 2016

Ugh. issue-36023.rs is failing because that particular LLVM bug in simplifycfg is present in LLVM 3.7...

@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 1, 2016

Yep, for now, this is blocked on #36138.

@alexcrichton
Copy link
Member

Ok, I've tried to fix that test in #36198

@alexcrichton alexcrichton mentioned this pull request Sep 1, 2016
Closed
@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 1, 2016

Temporarily cherry picked c6176f73049ecbc79662cb59ee3750fa750127f5

@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 2, 2016

Two failures:

test [run-make] run-make/atomic-lock-free ... FAILED
test [run-make] run-make/simd-ffi ... FAILED

@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 2, 2016

The errors for those failed tests.

@alexcrichton
Copy link
Member

Aha, that's been fixed in the makefiles but not in rustbuild. Maybe this patch will help?

@alexcrichton
Copy link
Member

It's green!

If you want to back out the min-llvm-version commit and squash the other up, I'll r+

@frewsxcv frewsxcv changed the title Transition Travis CI to use rustbuild. [WIP] Transition Travis CI to use rustbuild. Sep 2, 2016
@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 2, 2016

Squashed.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 2, 2016

📌 Commit 3a96fe3 has been approved by alexcrichton

@sophiajt
Copy link
Contributor

sophiajt commented Sep 2, 2016

@bors rollup

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 2, 2016
Rollup merge of rust-lang#36180 - frewsxcv:patch-33, r=alexcrichton
1bc229f 
Transition Travis CI to use rustbuild.
@sophiajt sophiajt mentioned this pull request Sep 2, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 2, 2016
Rollup merge of rust-lang#36180 - frewsxcv:patch-33, r=alexcrichton
4a8069d 
Transition Travis CI to use rustbuild.
@sophiajt sophiajt mentioned this pull request Sep 2, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 2, 2016
Rollup merge of rust-lang#36180 - frewsxcv:patch-33, r=alexcrichton
49125bd 
Transition Travis CI to use rustbuild.
@sophiajt sophiajt mentioned this pull request Sep 2, 2016
Merged
bors added a commit that referenced this pull request Sep 3, 2016
@bors
Auto merge of #36227 - jonathandturner:rollup, r=jonathandturner
100b309 
Rollup of 12 pull requests

- Successful merges: #35754, #35793, #36099, #36160, #36171, #36178, #36180, #36190, #36198, #36205, #36210, #36223
- Failed merges:
@bors bors merged commit 3a96fe3 into rust-lang:master Sep 3, 2016
@frewsxcv frewsxcv deleted the patch-33 branch September 3, 2016 04:09
@frewsxcv frewsxcv mentioned this pull request Sep 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@frewsxcv @rust-highfive @sanxiyn @alexcrichton @bors @sophiajt @nikomatsakis