Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler error E0558 to use new error format #36223

Merged
merged 1 commit into from
Sep 3, 2016

Conversation

abhiQmar
Copy link
Contributor

@abhiQmar abhiQmar commented Sep 2, 2016

Fixes #36196 part of #35233

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Sep 2, 2016

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 2, 2016

📌 Commit 2f2df2a has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 2, 2016
…andturner

Update compiler error E0558 to use new error format

Fixes rust-lang#36196 part of rust-lang#35233

r? @jonathandturner
@frewsxcv
Copy link
Member

frewsxcv commented Sep 2, 2016

There is a tidy issue here:

/build/src/libsyntax/attr.rs:441: line longer than 100 chars

@abhijeetbhagat Is it possible you could wrap the line to be shorter than 100 characters?

@sophiajt
Copy link
Contributor

sophiajt commented Sep 2, 2016

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 2, 2016

📌 Commit 18434f9 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 2, 2016
…andturner

Update compiler error E0558 to use new error format

Fixes rust-lang#36196 part of rust-lang#35233

r? @jonathandturner
bors added a commit that referenced this pull request Sep 3, 2016
Rollup of 12 pull requests

- Successful merges: #35754, #35793, #36099, #36160, #36171, #36178, #36180, #36190, #36198, #36205, #36210, #36223
- Failed merges:
@bors bors merged commit 18434f9 into rust-lang:master Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants