Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove variant MacroRulesTT of SyntaxExtension #36444

Merged
merged 4 commits into from
Sep 17, 2016
Merged

Remove variant MacroRulesTT of SyntaxExtension #36444

merged 4 commits into from
Sep 17, 2016

Conversation

jseyfried
Copy link
Contributor

r? @nrc

@jseyfried
Copy link
Contributor Author

cc @DanielJCampbell (the first commit moves single_step and keep_macs from #34811)

@DanielJCampbell
Copy link
Contributor

That seems like a better place for those flags, to be honest.

@nrc
Copy link
Member

nrc commented Sep 13, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 13, 2016

📌 Commit 95b1ad7 has been approved by nrc

@bors
Copy link
Contributor

bors commented Sep 14, 2016

⌛ Testing commit 95b1ad7 with merge 9617e42...

@bors
Copy link
Contributor

bors commented Sep 14, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Sep 13, 2016 at 7:44 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/2495

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36444 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95NN-i3ujWjJLKdGTfLsvU9Y8QV-Dks5qp190gaJpZM4J7W3J
.

@Manishearth Manishearth mentioned this pull request Sep 15, 2016
Merged
bors added a commit that referenced this pull request Sep 15, 2016
@bors
Auto merge of #36491 - Manishearth:rollup, r=Manishearth
dc75933 
Rollup of 9 pull requests

- Successful merges: #36384, #36405, #36425, #36429, #36438, #36454, #36459, #36461, #36463
- Failed merges: #36444
@bors
Copy link
Contributor

bors commented Sep 15, 2016

☔ The latest upstream changes (presumably #36491) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried
Copy link
Contributor Author

@bors r=nrc

@bors
Copy link
Contributor

bors commented Sep 15, 2016

📌 Commit f9a08cc has been approved by nrc

bors added a commit that referenced this pull request Sep 16, 2016
@bors
Auto merge of #36444 - jseyfried:macro_rules_ext, r=nrc
d4037fc 
Remove variant `MacroRulesTT` of `SyntaxExtension`

r? @nrc
@bors
Copy link
Contributor

bors commented Sep 16, 2016

⌛ Testing commit f9a08cc with merge d4037fc...

@bors
Copy link
Contributor

bors commented Sep 17, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing d4037fc to master...

@bors bors merged commit f9a08cc into rust-lang:master Sep 17, 2016
@jseyfried jseyfried deleted the macro_rules_ext branch September 17, 2016 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jseyfried @DanielJCampbell @nrc @bors @alexcrichton