Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invoke drop glue with a ptr to (data, meta) #36459

Merged
merged 2 commits into from
Sep 15, 2016
Merged

invoke drop glue with a ptr to (data, meta) #36459

merged 2 commits into from
Sep 15, 2016

Conversation

nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented Sep 13, 2016 •
edited
Loading

This is done by creating a little space on the stack. Hokey, but it's the simplest fix I can see, and I am in "kill regressions" mode right now.

Fixes #35546

r? @eddyb

@nikomatsakis
invoke drop glue with a ptr to (data, meta)
b49a26e 
This is done by creating a little space on the stack. Hokey, but it's
the simplest fix I can see.
@nikomatsakis nikomatsakis added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 13, 2016
@nikomatsakis
Copy link
Contributor Author

Nominating for beta: regression. (But it has not yet been r+'d!)

@eddyb
Copy link
Member

eddyb commented Sep 13, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Sep 13, 2016

📌 Commit b49a26e has been approved by eddyb

@nikomatsakis
Copy link
Contributor Author

@bors r=eddyb

@bors
Copy link
Contributor

bors commented Sep 13, 2016

📌 Commit 693676d has been approved by eddyb

@bors
Copy link
Contributor

bors commented Sep 14, 2016

⌛ Testing commit 693676d with merge 3e6a5ad...

@bors
Copy link
Contributor

bors commented Sep 14, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Sep 13, 2016 at 7:55 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/2494

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36459 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95JaRnhShlJ5Gdvr-1o6DfbnU9gALks5qp2IxgaJpZM4J8Hv5
.

@Manishearth Manishearth mentioned this pull request Sep 15, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 15, 2016
@Manishearth
Rollup merge of rust-lang#36459 - nikomatsakis:issue-35546, r=eddyb
959f764 
invoke drop glue with a ptr to (data, meta)

This is done by creating a little space on the stack. Hokey, but it's the simplest fix I can see, and I am in "kill regressions" mode right now.

Fixes rust-lang#35546

r? @eddyb
bors added a commit that referenced this pull request Sep 15, 2016
@bors
Auto merge of #36491 - Manishearth:rollup, r=Manishearth
dc75933 
Rollup of 9 pull requests

- Successful merges: #36384, #36405, #36425, #36429, #36438, #36454, #36459, #36461, #36463
- Failed merges: #36444
@bors bors merged commit 693676d into rust-lang:master Sep 15, 2016
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 19, 2016
@nikomatsakis
Copy link
Contributor Author

Accepting for beta. Relatively small patch, fixes regression.

@brson brson mentioned this pull request Sep 19, 2016
Merged
@pnkfelix
Copy link
Member

pnkfelix commented Sep 21, 2016 •
edited
Loading

@nikomatsakis Note for future: Please try to avoid extraneous whitespace/line break changes for PR's that are intended for the outset to be applied to beta. (A reason this PR failed to apply cleanly was two files that had solely comments added and line break /whitespace changes...)

  • (Okay, it had a few other problems too; namely it seems fn get_dataptr migrated from mod expr to mod base over time for some reason.)

@eddyb
Copy link
Member

eddyb commented Sep 21, 2016

@pnkfelix trans::expr was removed as part of old trans purging, but a few pieces survived elsewhere.

@pnkfelix
Copy link
Member

@eddyb ah I suppose that sort of delta is unavoidable then. Ah such tensions from refactoring.

@pnkfelix pnkfelix mentioned this pull request Sep 21, 2016
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 21, 2016
@nikomatsakis nikomatsakis deleted the issue-35546 branch April 14, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LLVM assertion failure with moving boxed DST
6 participants
@nikomatsakis @eddyb @bors @alexcrichton @pnkfelix @brson