-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite checked_{div,rem} to no contain any reference to panics #37029
Conversation
even without optimizations
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
While implementing this. I noticed that |
Hm I don't think |
@alexcrichton Oh, that makes sense. |
None | ||
} else { | ||
let (a, b) = self.overflowing_div(other); | ||
if b {None} else {Some(a)} | ||
Some(unsafe { intrinsics::unchecked_div(self, other) }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why intrinsic, not wrapping_div
?
EDIT: wrapping_div also has references to panic. I was thinking it used unchecked_div o.O.
…=alexcrichton rewrite checked_{div,rem} to no contain any reference to panics even without optimizations r? @alexcrichton
even without optimizations
r? @alexcrichton