-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #37039
Merged
Merged
Rollup of 6 pull requests #37039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves hacking the code used to run cargo test on various packages, because it reads Cargo.lock to determine which packages should be tested. This change implements a blacklist, since that will catch new crates when they are added in the future.
Some of the doc tests depend on `extern crate test`, so depend on libtest instead of libstd here.
even without optimizations
s/reigster/register/
This updates the commit to use workspaces to use `cargo metadata` instead of hardcoded lists about what to test. This should help us be resilient to updates in the future on behalf of the crate DAG and minimize the amount of files that need to be touched.
Fix documentation for `write!` on `std::fmt` page Fixes rust-lang#36906
Leverage Cargo workspaces in rustbuild This is a continuation of rust-lang#36032 which implements the change to use `cargo metadata` to learn about the crate graph.
rustbuild: Fix dependencies of check-docs step Some of the doc tests depend on `extern crate test`, so depend on libtest instead of libstd here.
…=alexcrichton rewrite checked_{div,rem} to no contain any reference to panics even without optimizations r? @alexcrichton
…lexcrichton Fix a typo in a comment describing gcc.rs's eh_frame_registry module s/reigster/register/ r? @alexcrichton
Do not add an empty #[derive()] list in expand_derive (fixes rust-lang#37033)
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ p=10 |
📌 Commit 69f4126 has been approved by |
⌛ Testing commit 69f4126 with merge 4344f14... |
bors
added a commit
that referenced
this pull request
Oct 8, 2016
This was referenced Oct 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write!
onstd::fmt
page #36937, Leverage Cargo workspaces in rustbuild #37016, rustbuild: Fix dependencies of check-docs step #37028, rewrite checked_{div,rem} to no contain any reference to panics #37029, Fix a typo in a comment describing gcc.rs's eh_frame_registry module #37031, Do not add an empty #[derive()] list in expand_derive (fixes #37033) #37034