Balance the debug output of Lvalue Subslice #37692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ rollup Thanks! |
|
📌 Commit 4ce4900 has been approved by |
alexcrichton
added
the
T-compiler
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 11, 2016
Balance the debug output of Lvalue Subslice The current debug output for Lvalue Subslice is not balanced and does not respect the comment[1], which indicates that we use `slice[from:-to] in Python terms.`. In python terms slices which have a start but no end are written as `a[start:]`, so following the comment, I fixed the output accordingly. Grep-ing over the sources, I did not found any test cases checking this subslice debug output. Note, I have not yet tested this change yet, as I am still waiting for the end of LLVM compilation. [1] https://manishearth.github.io/rust-internals-docs/rustc/mir/enum.ProjectionElem.html
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 12, 2016
Balance the debug output of Lvalue Subslice The current debug output for Lvalue Subslice is not balanced and does not respect the comment[1], which indicates that we use `slice[from:-to] in Python terms.`. In python terms slices which have a start but no end are written as `a[start:]`, so following the comment, I fixed the output accordingly. Grep-ing over the sources, I did not found any test cases checking this subslice debug output. Note, I have not yet tested this change yet, as I am still waiting for the end of LLVM compilation. [1] https://manishearth.github.io/rust-internals-docs/rustc/mir/enum.ProjectionElem.html
bors
added a commit
that referenced
this pull request
Nov 12, 2016
Rollup of 30 pull requests - Successful merges: #37190, #37368, #37481, #37503, #37527, #37535, #37551, #37584, #37600, #37613, #37615, #37659, #37662, #37669, #37682, #37688, #37690, #37692, #37693, #37694, #37695, #37696, #37698, #37699, #37705, #37708, #37709, #37716, #37724, #37727 - Failed merges: #37640, #37689, #37717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current debug output for Lvalue Subslice is not balanced and does not respect the comment[1], which indicates that we use
slice[from:-to] in Python terms.. In python terms slices which have a start but no end are written asa[start:], so following the comment, I fixed the output accordingly.Grep-ing over the sources, I did not found any test cases checking this subslice debug output.
Note, I have not yet tested this change yet, as I am still waiting for the end of LLVM compilation.
[1] https://manishearth.github.io/rust-internals-docs/rustc/mir/enum.ProjectionElem.html