rustbuild: allow overriding list of LLVM targets to build #38657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new option is introduced under the `[llvm]` section of `config.toml`, `targets`, for overriding the list of LLVM targets to build support for. The option is passed through to LLVM configure script. Also notes are added about the implications of (ab)using the option; since the default is not changed, and users of the option are expected to know what they're doing anyway (as every porter should), the impact should be minimal. Fixes rust-lang#38200.
| @@ -75,13 +75,18 @@ pub fn llvm(build: &Build, target: &str) { | |||
| (true, true) => "RelWithDebInfo", | |||
| }; | |||
|
|
|||
| // NOTE: remember to also update `config.toml.example` when changing the defaults! | |||
|
Cool! |
|
Wait there's the problem of stale cache when the target list has been changed. Most likely we'd like to revamp the current stamping logic to include the targets also, maybe ditching the date part altogether. I'll come up with something like that later in the day. |
|
@bors: r+ Looks good to me! I don't think we have to worry too much about stale issues here, presumably you know what you're doing if you're tweaking this configuration. |
|
📌 Commit 0f8e931 has been approved by |
|
Auto-rebuild would be cool though. |
|
@Yamakaky I've already implemented that in a local branch. Waiting for this PR to land, then I could publish it for review as it's directly built upon this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go!
r? @alexcrichton
cc @Yamakaky