Fix ICE on i686 when calling immediate() on OperandValue::Ref in return #38855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Jan 5, 2017
| @@ -223,7 +223,12 @@ impl<'a, 'tcx> MirContext<'a, 'tcx> { | |||
| load | |||
| } else { | |||
| let op = self.trans_consume(&bcx, &mir::Lvalue::Local(mir::RETURN_POINTER)); | |||
| op.pack_if_pair(&bcx).immediate() | |||
| let op_ref = op.pack_if_pair(&bcx); | |||
eddyb
added
beta-nominated
Mark-Simulacrum
force-pushed
the
immediate-fix
branch
from
b7f5080
to
97c008c
Compare
|
@bors r+ |
|
📌 Commit 97c008c has been approved by |
nikomatsakis
added
the
beta-accepted
|
Approved for beta. Small patch, regression. cc @rust-lang/compiler |
|
@bors: p=1 This is a backport |
|
⌛ Testing commit 97c008c with merge a754a23... |
|
💔 Test failed - status-travis |
|
@bors retry
|
|
⌛ Testing commit 97c008c with merge 7ecb5b7... |
|
💔 Test failed - status-travis |
|
@bors: retry
* osx network failure
…On Fri, Jan 6, 2017 at 8:26 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189549854>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38855 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95OYuXv0CoDfONwxMFDKjieUYEogoks5rPmtKgaJpZM4LcDNc>
.
|
nikomatsakis
added a commit
to nikomatsakis/rust
that referenced
this pull request
Jan 6, 2017
|
⌛ Testing commit 97c008c with merge 25bfc8a... |
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38727, and adds a test case.
r? @eddyb