Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta backports #38872

Merged
merged 18 commits into from
Jan 6, 2017
Merged

Beta backports #38872

merged 18 commits into from
Jan 6, 2017

Conversation

@rust-highfive
Copy link
Collaborator

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@nikomatsakis nikomatsakis assigned alexcrichton and unassigned nrc Jan 6, 2017
@nikomatsakis
Copy link
Contributor Author

nikomatsakis commented Jan 6, 2017

Argh. Seems like something didn't backport cleanly, probably the last PR.

Fixed.

@nikomatsakis nikomatsakis changed the title Most T-compiler beta backports Beta backports Jan 6, 2017
@alexcrichton
Copy link
Member

@nikomatsakis could you back out the backport of 4781eb3 (the second commit of #38708), we should only need the first commit I believe, specifically d0881ea

@alexcrichton
Copy link
Member

@nikomatsakis your list also claims #38792 was backported but the commits aren't showing up here for me?

@alexcrichton
Copy link
Member

Ok I updated the list in the PR description to also reflect whether the PRs have been merged or not. We have less testing on beta than we do on master, so I personally prefer to wait for a merge to master before backporting, but we can also just re-backport fixes if necessary.

@alexcrichton
Copy link
Member

I unchecked #38792 in the list above due to this comment

@nikomatsakis
Copy link
Contributor Author

@alexcrichton

your list also claims #38792 was backported but the commits aren't showing up here for me?

hmm, yeah, I somehow overlooked that one, but in the other case I had just forgotten to push

could you back out the backport of 4781eb3 (the second commit of #38708), we should only need the first commit I believe, specifically d0881ea

will do

@nikomatsakis
Copy link
Contributor Author

could you back out the backport of 4781eb3 (the second commit of #38708), we should only need the first commit I believe, specifically d0881ea

done

@brson
Copy link
Contributor

brson commented Jan 6, 2017

Wowee! This is amazing. Thanks @nikomatsakis

alexcrichton and others added 3 commits January 6, 2017 13:47
The source tarball creation step would attempt to skip a number of files that we
want to ignore ourselves, but once we've hit the vendor directory we don't want
to skip anything so be sure to vendor everything inside that directory.

Closes rust-lang#38690
This commit stabilizes the `proc_macro` and `proc_macro_lib` features in the
compiler to stabilize the "Macros 1.1" feature of the language. Many more
details can be found on the tracking issue, rust-lang#35900.

Closes rust-lang#35900
These are some bare-bones documentation for custom derive, needed
to stabilize "macros 1.1",
rust-lang#35900

The book chapter is based off of a blog post by @cbreeden,
https://cbreeden.github.io/Macros11/

Normally, we have a policy of not mentioning external crates in
documentation. However, given that syn/quote are basically neccesary
for properly using macros 1.1, I feel that not including them here
would make the documentation very bad. So the rules should be bent
in this instance.
@alexcrichton
Copy link
Member

Thanks @nikomatsakis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.