Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 15 pull requests #39613

Closed
wants to merge 37 commits into from
Closed

Rollup of 15 pull requests #39613

wants to merge 37 commits into from

Conversation

Aaron Power and others added 30 commits January 1, 2017 20:15
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
* Moved algorithm explanation to module docs
* Added ``` before and after the examples
* Explanation of the `rbox`, `ibox` and `cbox` names
* Added docs about the breaking types to `Breaks`
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
This landed on beta in rust-lang#39546 and this is bringing the patch back to master.
Right now all Cargo release tarballs are 'nightly', they're not on the standard
channels yet.
Even more SNAP cleanup.
Improve error message for uninferrable types rust-lang#38812

Hello,

I tried to improve the error message for uninferrable types. The error code is `E0282`.

```rust

error[E0282]: type annotations needed
 --> /home/cengizIO/issue38812.rs:2:11
  |
2 |   let x = vec![];
  |       -   ^^^^^^ cannot infer type for `T`
  |       |
  |       consider giving `x` a type
  |
  = note: this error originates in a macro outside of the current crate
```

and

```rust

error[E0282]: type annotations needed
 --> /home/cengizIO/issue38812.rs:2:15
  |
2 |   let (x,) = (vec![],);
  |       ----    ^^^^^^ cannot infer type for `T`
  |       |
  |       consider giving a type to pattern
  |
  = note: this error originates in a macro outside of the current crate
```

Rust compiler now tries to find uninferred `local`s with type `_` and adds them into the error message.

I'm probably wrong on wording that I used. Please feel free to suggest better alternatives.

Thanks @nikomatsakis for mentoring 🍺

Any comments/feedback is more than welcome!

Thank you
lint/ctypes: Don't warn on sized structs with PhantomData.

Fixes rust-lang#34798
A few documentation improvements for `syntax::print::pp`

* Moved algorithm explanation to module docs
* Added ``` before and after the examples
* Explanation of the `rbox`, `ibox` and `cbox` names
* Added docs about the breaking types to `Breaks`
…lexcrichton

Extract collections benchmarks to libcollections/bench

Good suggestion from @stjepang rust-lang#39484 (comment)

r? @alexcrichton
… r=michaelwoerister

Handle the case where an intermediate node can't be recreated

This solution grows the graph, but this is quite the corner case.

r? @michaelwoerister
…, r=nikomatsakis

back: Limit the number of LLVM worker threads.

This should fix issue rust-lang#39568.
Also see rust-lang#39280.

r? @nikomatsakis
rustbuild: support setting verbosity in config.toml

Most if not all the configuration is settable trhough config.toml but the verbosity isn't yet.

This avoids having to pass -v to x.py on each command if you want verbosity to be always on.
Fix branch name Cargo's downloaded from

This landed on beta in rust-lang#39546 and this is bringing the patch back to master.
…brson

Fix a manifest-generation bug on beta

Right now all Cargo release tarballs are 'nightly', they're not on the standard
channels yet.
…aarch64-unknown-freebsd, r=alexcrichton

liblibc: Update to include `aarch64-unknown-freebsd` support
Fix ICE when accessing mutably an immutable enum

Fix rust-lang#39544.
Unignore u128 test for stage 0,1

Even more SNAP cleanup.

Follow-up of rust-lang#39519.

Sorry, I didn't check twice.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 7, 2017

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Feb 7, 2017

📌 Commit 9d5dbeb has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented Feb 7, 2017

⌛ Testing commit 9d5dbeb with merge 17b6088...

@bors
Copy link
Contributor

bors commented Feb 7, 2017

💔 Test failed - status-travis

@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 7, 2017

@bors retry

@bors
Copy link
Contributor

bors commented Feb 7, 2017

⌛ Testing commit 9d5dbeb with merge 2a69008...

@bors
Copy link
Contributor

bors commented Feb 7, 2017

💔 Test failed - status-travis

@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 7, 2017

@bors retry

@bors
Copy link
Contributor

bors commented Feb 7, 2017

⌛ Testing commit 9d5dbeb with merge a4fb614...

bors added a commit that referenced this pull request Feb 7, 2017
Rollup of 15 pull requests

- Successful merges: #38764, #39361, #39426, #39462, #39482, #39557, #39561, #39582, #39583, #39587, #39598, #39599, #39601, #39602, #39604
- Failed merges:
@bors
Copy link
Contributor

bors commented Feb 7, 2017

💔 Test failed - status-travis

@frewsxcv frewsxcv closed this Feb 7, 2017
@frewsxcv frewsxcv deleted the rollup branch February 7, 2017 17:14
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.