Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Disable source tarballs on most builders #39824

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

alexcrichton
Copy link
Member

Currently we create a source tarball on almost all of the DEPLOY=1 builders
but this has the adverse side effect of all source tarballs overriding
themselves in the S3 bucket. Normally this is ok but unfortunately a source
tarball created on Windows is not buildable on Unix.

On Windows the vendored sources contain paths with \ characters in them which
when interpreted on Unix end up in "file not found" errors.

Instead of this overwriting behavior, whitelist just one linux builder for
producing tarballs and avoid producing tarballs on all other hosts.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Feb 14, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Feb 14, 2017

📌 Commit e23fa7e has been approved by brson

--host=$HOSTS \
--enable-extended \
--enable-sanitizers \
--disable-dist-src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, why is this line here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I'm not thinking correctly

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Feb 15, 2017

📌 Commit 4d71027 has been approved by brson

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 15, 2017
travis: Disable source tarballs on most builders

Currently we create a source tarball on almost all of the `DEPLOY=1` builders
but this has the adverse side effect of all source tarballs overriding
themselves in the S3 bucket. Normally this is ok but unfortunately a source
tarball created on Windows is not buildable on Unix.

On Windows the vendored sources contain paths with `\` characters in them which
when interpreted on Unix end up in "file not found" errors.

Instead of this overwriting behavior, whitelist just one linux builder for
producing tarballs and avoid producing tarballs on all other hosts.
bors added a commit that referenced this pull request Feb 16, 2017
Rollup of 11 pull requests

- Successful merges: #39775, #39793, #39804, #39824, #39834, #39837, #39839, #39840, #39843, #39844, #39846
- Failed merges:
@frewsxcv
Copy link
Member

It looks like this PR might have caused this error:

https://travis-ci.org/rust-lang/rust/jobs/202083203

@alexcrichton
Copy link
Member Author

@bors: r-

indeed quite likely!

Currently we create a source tarball on almost all of the `DEPLOY=1` builders
but this has the adverse side effect of all source tarballs overriding
themselves in the S3 bucket. Normally this is ok but unfortunately a source
tarball created on Windows is not buildable on Unix.

On Windows the vendored sources contain paths with `\` characters in them which
when interpreted on Unix end up in "file not found" errors.

Instead of this overwriting behavior, whitelist just one linux builder for
producing tarballs and avoid producing tarballs on all other hosts.
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Feb 16, 2017

📌 Commit 1902488 has been approved by brson

@bors
Copy link
Contributor

bors commented Feb 16, 2017

⌛ Testing commit 1902488 with merge ccd96c9...

bors added a commit that referenced this pull request Feb 16, 2017
travis: Disable source tarballs on most builders

Currently we create a source tarball on almost all of the `DEPLOY=1` builders
but this has the adverse side effect of all source tarballs overriding
themselves in the S3 bucket. Normally this is ok but unfortunately a source
tarball created on Windows is not buildable on Unix.

On Windows the vendored sources contain paths with `\` characters in them which
when interpreted on Unix end up in "file not found" errors.

Instead of this overwriting behavior, whitelist just one linux builder for
producing tarballs and avoid producing tarballs on all other hosts.
@bors
Copy link
Contributor

bors commented Feb 16, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing ccd96c9 to master...

@bors bors merged commit 1902488 into rust-lang:master Feb 16, 2017
@alexcrichton alexcrichton deleted the disable-dist-src branch March 8, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants