rustc: Link statically to the MSVCRT #39837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
3 tasks
|
@bors r+ |
|
📌 Commit b2c4e74 has been approved by |
brson
added
the
relnotes
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 15, 2017
rustc: Link statically to the MSVCRT This commit changes all MSVC rustc binaries to be compiled with `-C target-feature=+crt-static` to link statically against the MSVCRT instead of dynamically (as it does today). This also necessitates compiling LLVM in a different fashion, ensuring it's compiled with `/MT` instead of `/MD`. cc rust-lang#37406
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 16, 2017
rustc: Link statically to the MSVCRT This commit changes all MSVC rustc binaries to be compiled with `-C target-feature=+crt-static` to link statically against the MSVCRT instead of dynamically (as it does today). This also necessitates compiling LLVM in a different fashion, ensuring it's compiled with `/MT` instead of `/MD`. cc rust-lang#37406
|
@bors r- I'm going to guess these errors are relevant https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1974 |
|
They are indeed! @frewsxcv feel free to leave my PRs out of rollups, I tend to have a propensity to cause breakage... |
This commit changes all MSVC rustc binaries to be compiled with `-C target-feature=+crt-static` to link statically against the MSVCRT instead of dynamically (as it does today). This also necessitates compiling LLVM in a different fashion, ensuring it's compiled with `/MT` instead of `/MD`. cc rust-lang#37406
alexcrichton
force-pushed
the
llvm-crt-static
branch
from
b2c4e74
to
c02c44d
Compare
|
@bors: r=brson |
|
📌 Commit c02c44d has been approved by |
|
⌛ Testing commit c02c44d with merge 715ba66... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
* timed out
…On Thu, Feb 16, 2017 at 7:45 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1979>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39837 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95Gw3fhkreCPXnDHvFzieZl3GWENLks5rdFMTgaJpZM4MBSPu>
.
|
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2017
rustc: Link statically to the MSVCRT This commit changes all MSVC rustc binaries to be compiled with `-C target-feature=+crt-static` to link statically against the MSVCRT instead of dynamically (as it does today). This also necessitates compiling LLVM in a different fashion, ensuring it's compiled with `/MT` instead of `/MD`. cc rust-lang#37406
|
⌛ Testing commit c02c44d with merge 309a294... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network error
…On Fri, Feb 17, 2017 at 12:40 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/202719140>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39837 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95A2qSBjpHWhfLQj2ToDBw7bI7me4ks5rdemRgaJpZM4MBSPu>
.
|
|
⌛ Testing commit c02c44d with merge 01dc103... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
|
|
⌛ Testing commit c02c44d with merge 6429d91... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
* network failure
…On Fri, Feb 17, 2017 at 1:33 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2007>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39837 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95PKf7JuD6SKgOR8nURN2Q3zVNiXvks5rdfXwgaJpZM4MBSPu>
.
|
|
⌛ Testing commit c02c44d with merge 2b11f48... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network issues
…On Fri, Feb 17, 2017 at 2:44 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/202754462>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39837 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95OaRzRW4qcdmfkwV8rdoLfqbkZ9Iks5rdgaZgaJpZM4MBSPu>
.
|
bors
added a commit
that referenced
this pull request
Feb 17, 2017
rustc: Link statically to the MSVCRT This commit changes all MSVC rustc binaries to be compiled with `-C target-feature=+crt-static` to link statically against the MSVCRT instead of dynamically (as it does today). This also necessitates compiling LLVM in a different fashion, ensuring it's compiled with `/MT` instead of `/MD`. cc #37406
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes all MSVC rustc binaries to be compiled with
-C target-feature=+crt-staticto link statically against the MSVCRT instead ofdynamically (as it does today). This also necessitates compiling LLVM in a
different fashion, ensuring it's compiled with
/MTinstead of/MD.cc #37406