-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the filenames of .stamp files generated by compiletest shorter #40578
Make the filenames of .stamp files generated by compiletest shorter #40578
Conversation
@michaelwoerister |
I... have no idea how to resolve this PR and @petrochenkov's comment... |
Well, if it is a desired feature to make these filenames predictable, we have to find another solution. We could, for example, have sub-dirs for host, target, and stage-name. That would make the path a bit longer, but the filenames shorter. |
Maybe add a rustbuild command for ignoring tests? |
I don't really mind how the needle is threaded here. It sounds like @michaelwoerister and @petrochenkov want their needles threaded though |
That would be more ergonomic than having to create a bunch files the names of which are still rather cumbersome to generate/remember. |
1189222
to
cbe1bd4
Compare
I've updated the code to just omit the Before:
After:
This fixes the problem for the current maximum test-filename length. |
@bors: r+ |
📌 Commit cbe1bd4 has been approved by |
🔒 Merge conflict |
Otherwise we run into filename length limitations on some file systems (especially ecryptfs).
cbe1bd4
to
cbb3af1
Compare
@bors r=alexcrichton |
📌 Commit cbb3af1 has been approved by |
…t-stamps, r=alexcrichton Make the filenames of .stamp files generated by compiletest shorter Otherwise we run into filename length limitations on some file systems. See https://bugs.launchpad.net/ecryptfs/+bug/344878 for an example where we only can have ~145 characters for filenames. r? @alexcrichton
Otherwise we run into filename length limitations on some file systems. See https://bugs.launchpad.net/ecryptfs/+bug/344878 for an example where we only can have ~145 characters for filenames.
r? @alexcrichton