Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the filenames of .stamp files generated by compiletest shorter #40578

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

michaelwoerister
Copy link
Member

Otherwise we run into filename length limitations on some file systems. See https://bugs.launchpad.net/ecryptfs/+bug/344878 for an example where we only can have ~145 characters for filenames.

r? @alexcrichton

@petrochenkov
Copy link
Contributor

@michaelwoerister
These files are supposed to be manually creatable (touch test_name-etc-etc-etc.stamp) for skipping tests, this change makes it impossible.

@alexcrichton
Copy link
Member

I... have no idea how to resolve this PR and @petrochenkov's comment...

@michaelwoerister
Copy link
Member Author

Well, if it is a desired feature to make these filenames predictable, we have to find another solution. We could, for example, have sub-dirs for host, target, and stage-name. That would make the path a bit longer, but the filenames shorter.

@arielb1
Copy link
Contributor

arielb1 commented Mar 16, 2017

@alexcrichton

Maybe add a rustbuild command for ignoring tests?

@alexcrichton
Copy link
Member

I don't really mind how the needle is threaded here. It sounds like @michaelwoerister and @petrochenkov want their needles threaded though

@michaelwoerister
Copy link
Member Author

Maybe add a rustbuild command for ignoring tests?

That would be more ergonomic than having to create a bunch files the names of which are still rather cumbersome to generate/remember.

@michaelwoerister michaelwoerister force-pushed the shorter-compiletest-stamps branch from 1189222 to cbe1bd4 Compare March 20, 2017 11:04
@michaelwoerister
Copy link
Member Author

I've updated the code to just omit the -H-<host>-T-<target> part. The host triple is already part of the path and the target triple is duplicated in the stage-id, so everything should still be unambiguous.

Before:

E0001.rs-H-x86_64-unknown-linux-gnu-T-x86_64-unknown-linux-gnu-S-stage1-x86_64-unknown-linux-gnu.stamp

After:

E0001.rs-stage1-x86_64-unknown-linux-gnu.stamp

This fixes the problem for the current maximum test-filename length.

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 20, 2017

📌 Commit cbe1bd4 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 21, 2017

🔒 Merge conflict

Otherwise we run into filename length limitations on some file
systems (especially ecryptfs).
@retep998 retep998 force-pushed the shorter-compiletest-stamps branch from cbe1bd4 to cbb3af1 Compare March 21, 2017 20:50
@bstrie
Copy link
Contributor

bstrie commented Mar 21, 2017

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit cbb3af1 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 22, 2017
…t-stamps, r=alexcrichton

Make the filenames of .stamp files generated by compiletest shorter

Otherwise we run into filename length limitations on some file systems. See https://bugs.launchpad.net/ecryptfs/+bug/344878 for an example where we only can have ~145 characters for filenames.

r? @alexcrichton
bors added a commit that referenced this pull request Mar 22, 2017
Rollup of 13 pull requests

- Successful merges: #40509, #40523, #40548, #40578, #40619, #40689, #40690, #40692, #40704, #40722, #40723, #40725, #40732
- Failed merges:
@bors bors merged commit cbb3af1 into rust-lang:master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants