-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
str: Make docs consistently punctuated #40692
str: Make docs consistently punctuated #40692
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! @bors r+ rollup |
📌 Commit e3da6e7 has been approved by |
Travis apparently hiccuped, but I don't have the authority to kick it. |
I could kick it, but I'm pretty sure your changes won't fail any tests, so probably not worth a two hour build ;) Your changes are queued up to be tested and merged: https://buildbot2.rust-lang.org/homu/queue/rust |
🔒 Merge conflict |
I've rebased this branch due to a submodule conflict that invalidated many PRs. |
@bors r+ rollup |
📌 Commit 49db656 has been approved by |
…uation, r=bstrie str: Make docs consistently punctuated Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the [other public structs](https://doc.rust-lang.org/std/str/index.html#structs) have descriptions that end in a full-stop).
…uation, r=bstrie str: Make docs consistently punctuated Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the [other public structs](https://doc.rust-lang.org/std/str/index.html#structs) have descriptions that end in a full-stop).
…uation, r=bstrie str: Make docs consistently punctuated Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the [other public structs](https://doc.rust-lang.org/std/str/index.html#structs) have descriptions that end in a full-stop).
Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the other public structs have descriptions that end in a full-stop).