Fix invalid debug display for associated consts #40587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GuillaumeGomez Have a screenshot of the added test handy? |
GuillaumeGomez
force-pushed
the
rustdoc-const-display
branch
from
0ae1dc4 to
5364acb
Compare
|
Sure:
|
|
Out of curiosity, do we show both the struct and the fields today? I wasn't sure if that was something that was part of this PR. |
|
We do (take a look at the issue). |
|
From looking here https://api.rocket.rs/rocket/http/struct.ContentType.html it seems like your screenshot doesn't reflect what it will look like. Do you have one that's closer to the original in terms of the amount of content? |
|
@jonathandturner: I have absolutely no idea how to run a specific binary from |
|
This seems fine to me. Unless @jonathandturner has any other questions here, r=me |
|
I'm good |
|
@bors: r=frewsxcv |
|
📌 Commit 5364acb has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 20, 2017
…y, r=frewsxcv Fix invalid debug display for associated consts Fixes rust-lang#40568. r? @rust-lang/docs cc @SergioBenitez
bors
added a commit
that referenced
this pull request
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40568.
r? @rust-lang/docs
cc @SergioBenitez