Rename TryFrom's associated type and implement str::parse using TryFrom. #40281

jimmycuadra · 2017-03-05T21:26:05Z

Per discussion on the tracking issue, naming TryFrom's associated type Error is generally more consistent with similar traits in the Rust ecosystem, and what people seem to assume it should be called. It also helps disambiguate from Result::Err, the most common "Err".

See #33417 (comment).

TryFrom<&str> and FromStr are equivalent, so have the latter provide the former to ensure that. Using TryFrom in the implementation of str::parse means types that implement either trait can use it. When we're ready to stabilize TryFrom, we should update FromStr to
suggest implementing TryFrom<&str> instead for new code.

See #33417 (comment)
and #33417 (comment).

Refs #33417.

rust-highfive · 2017-03-05T21:26:12Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

sfackler · 2017-03-05T23:37:23Z

This seems reasonable to me, though I'm not sure if that blanket impl will conflict with any other's we may want to add (e.g. impl<T, U> TryFrom<U> for T where T: From<U>).

alexcrichton · 2017-03-06T16:40:29Z

The renaming also sounds fine to me, yeah, but I agree that I'm less sure of the coherence impact of the blanket impl here. It definitely seems desirable but I'd want to make sure it doesn't otherwise forbid useful TryFrom impls.

(regardless due to a change in signature we'll likely want to do a crater run just to make sure)

aturon · 2017-03-14T20:39:04Z

We discussed this PR in the libs team triage, and are happy to go in this directions. Thanks @jimmycuadra!

@bors: r+

bors · 2017-03-14T20:39:06Z

📌 Commit 7fe2e7e has been approved by aturon

bors · 2017-03-15T09:53:27Z

🔒 Merge conflict

Per discussion on the tracking issue, naming `TryFrom`'s associated type `Error` is generally more consistent with similar traits in the Rust ecosystem, and what people seem to assume it should be called. It also helps disambiguate from `Result::Err`, the most common "Err". See #33417 (comment). TryFrom<&str> and FromStr are equivalent, so have the latter provide the former to ensure that. Using TryFrom in the implementation of `str::parse` means types that implement either trait can use it. When we're ready to stabilize `TryFrom`, we should update `FromStr` to suggest implementing `TryFrom<&str>` instead for new code. See #33417 (comment) and #33417 (comment). Refs #33417.

alexcrichton · 2017-03-15T14:52:32Z

@bors: r=aturon

bors · 2017-03-15T14:52:33Z

📌 Commit 2561dcd has been approved by aturon

…uron Rename TryFrom's associated type and implement str::parse using TryFrom. Per discussion on the tracking issue, naming `TryFrom`'s associated type `Error` is generally more consistent with similar traits in the Rust ecosystem, and what people seem to assume it should be called. It also helps disambiguate from `Result::Err`, the most common "Err". See rust-lang#33417 (comment). `TryFrom<&str>` and `FromStr` are equivalent, so have the latter provide the former to ensure that. Using `TryFrom` in the implementation of `str::parse` means types that implement either trait can use it. When we're ready to stabilize `TryFrom`, we should update `FromStr` to suggest implementing `TryFrom<&str>` instead for new code. See rust-lang#33417 (comment) and rust-lang#33417 (comment). Refs rust-lang#33417.

bors · 2017-03-19T10:34:12Z

⌛ Testing commit 2561dcd with merge 432843b...

bors · 2017-03-19T10:56:06Z

💔 Test failed - status-travis

arielb1 · 2017-03-19T11:40:28Z

sccache broken pipe:

DEBUG:sccache::compiler::compiler: parse_arguments: `-DGTEST_HAS_RTTI=0 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/llvm/build/lib/MC -I/Users/travis/build/rust-lang/rust/src/llvm/lib/MC -I/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/llvm/build/include -I/Users/travis/build/rust-lang/rust/src/llvm/include -ffunction-sections -fdata-sections -fPIC -m32 -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Werror=date-time -std=c++11 -O3 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.8 -UNDEBUG -fno-exceptions -fno-rtti -o CMakeFiles/LLVMMC.dir/MCCodeEmitter.cpp.o -c /Users/travis/build/rust-lang/rust/src/llvm/lib/MC/MCCodeEmitter.cpp`

DEBUG:sccache::compiler::compiler: parse_arguments: Ok

DEBUG:sccache::compiler::compiler: [MCCodeEmitter.cpp.o]: get_cached_or_compile: -DGTEST_HAS_RTTI=0 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/llvm/build/lib/MC -I/Users/travis/build/rust-lang/rust/src/llvm/lib/MC -I/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/llvm/build/include -I/Users/travis/build/rust-lang/rust/src/llvm/include -ffunction-sections -fdata-sections -fPIC -m32 -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Werror=date-time -std=c++11 -O3 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.8 -UNDEBUG -fno-exceptions -fno-rtti -o CMakeFiles/LLVMMC.dir/MCCodeEmitter.cpp.o -c /Users/travis/build/rust-lang/rust/src/llvm/lib/MC/MCCodeEmitter.cpp

DEBUG:sccache::compiler::compiler: [MCCodeEmitter.cpp.o]: preprocessor failed: Error(Msg("failed to spawn child"), State { next_error: Some(Error { repr: Os { code: 32, message: "Broken pipe" } }) })

@bors retry

arielb1 · 2017-03-19T11:54:10Z

@alexcrichton - why is spawn of all things returning EPIPE? It does not seem to do anything that could cause that error.

bors · 2017-03-19T13:57:21Z

⌛ Testing commit 2561dcd with merge 37e4c14...

arielb1 · 2017-03-19T17:43:58Z

Mac builders not starting. Someone call travis.

@bors retry

…uron Rename TryFrom's associated type and implement str::parse using TryFrom. Per discussion on the tracking issue, naming `TryFrom`'s associated type `Error` is generally more consistent with similar traits in the Rust ecosystem, and what people seem to assume it should be called. It also helps disambiguate from `Result::Err`, the most common "Err". See rust-lang#33417 (comment). `TryFrom<&str>` and `FromStr` are equivalent, so have the latter provide the former to ensure that. Using `TryFrom` in the implementation of `str::parse` means types that implement either trait can use it. When we're ready to stabilize `TryFrom`, we should update `FromStr` to suggest implementing `TryFrom<&str>` instead for new code. See rust-lang#33417 (comment) and rust-lang#33417 (comment). Refs rust-lang#33417.

bors · 2017-03-20T05:36:41Z

⌛ Testing commit 2561dcd with merge 6738cd4...

Rename TryFrom's associated type and implement str::parse using TryFrom. Per discussion on the tracking issue, naming `TryFrom`'s associated type `Error` is generally more consistent with similar traits in the Rust ecosystem, and what people seem to assume it should be called. It also helps disambiguate from `Result::Err`, the most common "Err". See #33417 (comment). `TryFrom<&str>` and `FromStr` are equivalent, so have the latter provide the former to ensure that. Using `TryFrom` in the implementation of `str::parse` means types that implement either trait can use it. When we're ready to stabilize `TryFrom`, we should update `FromStr` to suggest implementing `TryFrom<&str>` instead for new code. See #33417 (comment) and #33417 (comment). Refs #33417.

bors · 2017-03-20T08:31:12Z

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 6738cd4 to master...

Rollup of 9 pull requests - Successful merges: #40241, #40281, #40398, #40521, #40532, #40554, #40566, #40581, #40587 - Failed merges:

related: rust-lang/rust#40281

rust-lang/rust#40281

This is due to rust-lang/rust#40281.

@sfackler

Add blanket TryFrom impl when From is implemented. Adds `impl<T, U> TryFrom<T> for U where U: From<T>`. Removes `impl<'a, T> TryFrom<&'a str> for T where T: FromStr` (originally added in #40281) due to overlapping impls caused by the new blanket impl. This removal is to be discussed further on the tracking issue for TryFrom. Refs #33417. /cc @sfackler, @scottmcm (thank you for the help!), and @aturon

rust-highfive assigned aturon Mar 5, 2017

alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 6, 2017

frewsxcv mentioned this pull request Mar 17, 2017

Rollup of 15 pull requests #40615

Closed

frewsxcv mentioned this pull request Mar 17, 2017

Rollup of 16 pull requests #40616

Closed

frewsxcv mentioned this pull request Mar 17, 2017

Rollup of 12 pull requests #40618

Closed

frewsxcv mentioned this pull request Mar 18, 2017

Rollup of 8 pull requests #40633

Closed

frewsxcv mentioned this pull request Mar 18, 2017

Rollup of 9 pull requests #40635

Closed

frewsxcv mentioned this pull request Mar 18, 2017

Rollup of 20 pull requests #40643

Closed

frewsxcv mentioned this pull request Mar 19, 2017

Rollup of 8 pull requests #40656

Closed

frewsxcv mentioned this pull request Mar 20, 2017

Rollup of 9 pull requests #40659

Merged

bors added a commit that referenced this pull request Mar 20, 2017

Auto merge of #40659 - frewsxcv:rollup, r=frewsxcv

244f893

Rollup of 9 pull requests - Successful merges: #40241, #40281, #40398, #40521, #40532, #40554, #40566, #40581, #40587 - Failed merges:

bors merged commit 2561dcd into rust-lang:master Mar 20, 2017

jimmycuadra deleted the try-from-from-str branch March 20, 2017 08:35

mcginty added a commit to mcginty/snow that referenced this pull request Mar 21, 2017

accomodate change in nightly TryFrom

6813559

related: rust-lang/rust#40281

Emilgardis added a commit to Emilgardis/ATM-machine that referenced this pull request Mar 26, 2017

Use new TryFrom, see rust-lang/rust#40281

f129cdc

TedDriggs added a commit to TedDriggs/rust-derive-builder that referenced this pull request Apr 11, 2017

TryFrom's associated type was changed from Err to Error

c629cbd

rust-lang/rust#40281

TedDriggs mentioned this pull request Apr 11, 2017

Add try_setter option and generate appropriate methods colin-kiegel/rust-derive-builder#72

Merged

Lukazoid added a commit to Lukazoid/lz_quic that referenced this pull request Apr 20, 2017

Renamed TryFrom associated type Err to Error

885b34b

This is due to rust-lang/rust#40281.

scottmcm mentioned this pull request Jun 28, 2017

Tracking issue for ops::Try (try_trait feature) #42327

Closed

11 tasks

jimmycuadra mentioned this pull request Aug 30, 2017

Add blanket TryFrom impl when From is implemented. #44174

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename TryFrom's associated type and implement str::parse using TryFrom. #40281

Rename TryFrom's associated type and implement str::parse using TryFrom. #40281

jimmycuadra commented Mar 5, 2017

rust-highfive commented Mar 5, 2017

sfackler commented Mar 5, 2017

alexcrichton commented Mar 6, 2017

aturon commented Mar 14, 2017

bors commented Mar 14, 2017

bors commented Mar 15, 2017

alexcrichton commented Mar 15, 2017

bors commented Mar 15, 2017

bors commented Mar 19, 2017

bors commented Mar 19, 2017

arielb1 commented Mar 19, 2017

arielb1 commented Mar 19, 2017 •

edited

Loading

bors commented Mar 19, 2017

arielb1 commented Mar 19, 2017

bors commented Mar 20, 2017

bors commented Mar 20, 2017

Rename TryFrom's associated type and implement str::parse using TryFrom. #40281

Rename TryFrom's associated type and implement str::parse using TryFrom. #40281

Conversation

jimmycuadra commented Mar 5, 2017

rust-highfive commented Mar 5, 2017

sfackler commented Mar 5, 2017

alexcrichton commented Mar 6, 2017

aturon commented Mar 14, 2017

bors commented Mar 14, 2017

bors commented Mar 15, 2017

alexcrichton commented Mar 15, 2017

bors commented Mar 15, 2017

bors commented Mar 19, 2017

bors commented Mar 19, 2017

arielb1 commented Mar 19, 2017

arielb1 commented Mar 19, 2017 • edited Loading

bors commented Mar 19, 2017

arielb1 commented Mar 19, 2017

bors commented Mar 20, 2017

bors commented Mar 20, 2017

arielb1 commented Mar 19, 2017 •

edited

Loading