Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc to accept # at the start of a markdown file #40560 #40828

Merged
merged 1 commit into from
Mar 29, 2017
Merged

rustdoc to accept # at the start of a markdown file #40560 #40828

merged 1 commit into from
Mar 29, 2017

Conversation

projektir
Copy link
Contributor

@projektir projektir commented Mar 25, 2017 •
edited
Loading

This may be a bit odd if # and % lines are mixed up, but that's not something I've found while doing my search and replace.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

Awesome, I'll try to check this out soon.

@steveklabnik
Copy link
Member

steveklabnik commented Mar 27, 2017 •
edited
Loading

@bors: r+

looks good to me!

Some context: this isn't valid markdown. Rustdoc has supported only this for a long time, but as we want to transition the ecosystem to pulldown-cmark, being able to write things with # is important. So this would be the start towards deprecating %.

@brson , tagging this relnotes so we can advertise it to start that process.

@bors
Copy link
Contributor

bors commented Mar 27, 2017

📌 Commit 2e14bfe has been approved by steveklabnik

@steveklabnik steveklabnik added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 27, 2017
@bors
Copy link
Contributor

bors commented Mar 27, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Mar 27, 2017

📌 Commit 2e14bfe has been approved by steveklabnik

@alexcrichton alexcrichton mentioned this pull request Mar 27, 2017
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2017
@alexcrichton
Rollup merge of rust-lang#40828 - projektir:markdown_metadata, r=stev…
4d93c12 
…eklabnik

rustdoc to accept `#` at the start of a markdown file rust-lang#40560

This may be a bit odd if `#` and `%` lines are mixed up, but that's not something I've found while doing my search and replace.
bors added a commit that referenced this pull request Mar 27, 2017
@bors
Auto merge of #40867 - alexcrichton:rollup, r=alexcrichton
32a2d73 
Rollup of 19 pull requests

- Successful merges: #40317, #40516, #40524, #40606, #40683, #40751, #40778, #40813, #40818, #40819, #40824, #40828, #40832, #40833, #40837, #40849, #40852, #40853, #40865
- Failed merges:
bors added a commit that referenced this pull request Mar 28, 2017
@bors
Auto merge of #40867 - alexcrichton:rollup, r=alexcrichton
07a3429 
Rollup of 19 pull requests

- Successful merges: #40317, #40516, #40524, #40606, #40683, #40751, #40778, #40813, #40818, #40819, #40824, #40828, #40832, #40833, #40837, #40849, #40852, #40853, #40865
- Failed merges:
@bors bors merged commit 2e14bfe into rust-lang:master Mar 29, 2017
@projektir projektir deleted the markdown_metadata branch April 7, 2017 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@projektir @rust-highfive @steveklabnik @bors