Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 19 pull requests #40867

Merged
merged 46 commits into from
Mar 29, 2017
Merged

Rollup of 19 pull requests #40867

merged 46 commits into from
Mar 29, 2017

Conversation

nrc and others added 30 commits March 23, 2017 16:32
This alters the stdio code on Windows to always call `GetStdHandle` whenever the
stdio read/write functions are called as this allows us to track changes to the
value over time (such as if a process calls `SetStdHandle` while it's running).

Closes rust-lang#40490
This "on-demand" task both checks for errors and computes the custom
unsized kind, if any. This task is only defined on impls of
`CoerceUnsized`; invoking it on any other kind of impl results in a bug.
This is just to avoid having an `Option`, could easily be changed.
There are now 3 queries:

- inherent_impls(def-id): for a given type, get a `Rc<Vec<DefId>>` with
  all its inherent impls. This internally uses `crate_inherent_impls`,
  doing some hacks to keep the current deps (which, btw, are not clearly
  correct).
- crate_inherent_impls(crate): gathers up a map from types
  to `Rc<Vec<DefId>>`, touching the entire krate, possibly generating
  errors.
- crate_inherent_impls_overlap_check(crate): performs overlap checks
  between the inherent impls for a given type, generating errors.
I'm not really sure what we want the cadence here to be. We'll at the very least
update the Cargo submodule right before all releases, but otherwise I figured we
could just do it whenever needed or otherwise weekly (or something like that).

In any case, I don't have a super strong particular reason to do this, it's just
been a week or so since the release!
Select 3 random points instead of just 1.
Also the code now compiles on 16bit architectures.
The docs need to be built with the rustbuild feature so the correct
stability attributes (rustc_private) get applied.
This makes sure RFC links point to the RFC text not the pull request.
It looks like the 6.3.0 MinGW comes with a gdb which has issues (rust-lang#40184) that an
attempted workaround (rust-lang#40777) does not actually fix (rust-lang#40835). The original
motivation for upgradin MinGW was to fix build flakiness (rust-lang#40546) due to newer
builds not exhibiting the same bug, so let's hope that 6.2.0 isn't too far back
in time and still contains the fix we need.

Closes rust-lang#40835
Update libc to 0.2.21

Update to include android aarch64 and x86 improvements.
…uron

std: Don't cache stdio handles on Windows

This alters the stdio code on Windows to always call `GetStdHandle` whenever the
stdio read/write functions are called as this allows us to track changes to the
value over time (such as if a process calls `SetStdHandle` while it's running).

Closes rust-lang#40490
@bors
Copy link
Contributor

bors commented Mar 28, 2017

⌛ Testing commit 61928a0 with merge e6746a5...

@arielb1
Copy link
Contributor

arielb1 commented Mar 28, 2017

Travis shutdown:

@bors retry

@bors
Copy link
Contributor

bors commented Mar 28, 2017

⌛ Testing commit 61928a0 with merge 328ee68...

@bors
Copy link
Contributor

bors commented Mar 28, 2017

⌛ Testing commit 61928a0 with merge 2e2c3dc...

@arielb1
Copy link
Contributor

arielb1 commented Mar 28, 2017

Travis shutdown:

@bors retry

@bors
Copy link
Contributor

bors commented Mar 28, 2017

⌛ Testing commit 61928a0 with merge edeafc8...

@bors
Copy link
Contributor

bors commented Mar 28, 2017

💔 Test failed - status-appveyor

@arielb1
Copy link
Contributor

arielb1 commented Mar 28, 2017

[1325/1629] Linking CXX static library lib\libLLVMSystemZDisassembler.a
FAILED: lib/libLLVMSystemZDisassembler.a 
cmd.exe /C "cd . && "C:\Program Files (x86)\CMake\bin\cmake.exe" -E remove lib\libLLVMSystemZDisassembler.a && C:\projects\rust\mingw64\bin\ar.exe qc lib\libLLVMSystemZDisassembler.a  lib/Target/SystemZ/Disassembler/CMakeFiles/LLVMSystemZDisassembler.dir/SystemZDisassembler.cpp.obj && C:\projects\rust\mingw64\bin\ranlib.exe lib\libLLVMSystemZDisassembler.a && cd ."
C:\projects\rust\mingw64\bin\ar.exe: unable to rename 'lib\libLLVMSystemZDisassembler.a'; reason: No such file or directory
[1326/1629] Linking CXX static library lib\libLLVMSystemZAsmPrinter.a
ninja: build stopped: subcommand failed.
thread 'main' panicked at '
command did not execute successfully, got: exit code: 1

sccache failure?

@arielb1
Copy link
Contributor

arielb1 commented Mar 28, 2017

@bors retry

@bors
Copy link
Contributor

bors commented Mar 28, 2017

⌛ Testing commit 61928a0 with merge f099f90...

@bors
Copy link
Contributor

bors commented Mar 28, 2017

💔 Test failed - status-appveyor

@arielb1
Copy link
Contributor

arielb1 commented Mar 28, 2017

@bors retry ?

@bors
Copy link
Contributor

bors commented Mar 28, 2017

⌛ Testing commit 61928a0 with merge 07a3429...

bors added a commit that referenced this pull request Mar 28, 2017
@bors
Copy link
Contributor

bors commented Mar 29, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 07a3429 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.