-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update various book modules #40864
Merged
Merged
Update various book modules #40864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bors: r+ |
📌 Commit c4dc439 has been approved by |
@bors: r- sorry, this fails tidy. fixing. |
This includes an important fix for rustc contributors in rust-lang/book#571 I'm going to update the other ones as well here while we're at it; no need to spam PRs.
steveklabnik
force-pushed
the
update-submodules
branch
from
March 27, 2017 21:42
c4dc439
to
434e601
Compare
@bors: r=nrc sorry about that! |
📌 Commit 434e601 has been approved by |
@bors: p=1 I'm giving this one a priority because it's gonna mess with other contributors until it lands; I don't want people to have submodule pain. |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 29, 2017
Update various book modules This includes an important fix for rustc contributors in rust-lang/book#571 I'm going to update the other ones as well here while we're at it; no need to spam PRs. r? @nrc
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 29, 2017
Update various book modules This includes an important fix for rustc contributors in rust-lang/book#571 I'm going to update the other ones as well here while we're at it; no need to spam PRs. r? @nrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes an important fix for rustc contributors in
rust-lang/book#571
I'm going to update the other ones as well here while we're at it; no
need to spam PRs.
r? @nrc