Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: Stabilize the #![windows_subsystem] attribute #40870

Merged
merged 1 commit into from
Apr 5, 2017
Merged

rustc: Stabilize the #![windows_subsystem] attribute #40870

merged 1 commit into from
Apr 5, 2017

Conversation

alexcrichton
Copy link
Member

This commit stabilizes the #![windows_subsystem] attribute which is a
conservative exposure of the /SUBSYSTEM linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes #37499

@rust-highfive
Copy link
Collaborator

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

Note that documentation, not currently present, was implemented in rust-lang/reference#16 and is being pulled in as part of #40864

@liigo
Copy link
Contributor

liigo commented Mar 27, 2017

Should wait for open issue #37553 ?

@nrc
Copy link
Member

nrc commented Mar 28, 2017

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned nrc Mar 28, 2017
@alexcrichton
Copy link
Member Author

@nrc but I sent the PR :(

@liigo that would be a backwards compatible extension to the current attribute, so I don't see why it would block this.

@aturon
Copy link
Member

aturon commented Mar 30, 2017

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 30, 2017

📌 Commit 20888b1 has been approved by aturon

@frewsxcv frewsxcv mentioned this pull request Mar 30, 2017
Closed
@frewsxcv
Copy link
Member

@bors r-

Any chance you could remove the relevant section from the Unstable Book?

If #40694 lands before this, you'll get a tidy error for this PR as is.

@alexcrichton
Copy link
Member Author

Certainly, I'll tackle that soon.

@alexcrichton
rustc: Stabilize the #![windows_subsystem] attribute
34cf288 
This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
@alexcrichton alexcrichton force-pushed the stabilize-windows-subsystem branch from 20888b1 to 34cf288 Compare April 1, 2017 13:36
@alexcrichton
Copy link
Member Author

@bors: r=aturon

@bors
Copy link
Contributor

bors commented Apr 1, 2017

📌 Commit 34cf288 has been approved by aturon

@frewsxcv frewsxcv mentioned this pull request Apr 1, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
aaade9a 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
@frewsxcv frewsxcv mentioned this pull request Apr 2, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
69dfab8 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
@frewsxcv frewsxcv mentioned this pull request Apr 2, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
9fd0a18 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
@frewsxcv frewsxcv mentioned this pull request Apr 3, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
3b1f3f0 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
@frewsxcv frewsxcv mentioned this pull request Apr 3, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
8aa3494 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
@frewsxcv frewsxcv mentioned this pull request Apr 4, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
ae3ad90 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
@frewsxcv frewsxcv mentioned this pull request Apr 4, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Apr 4, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
14a7dd4 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
0239880 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
@frewsxcv frewsxcv mentioned this pull request Apr 5, 2017
Merged
bors added a commit that referenced this pull request Apr 5, 2017
@bors
Auto merge of #41086 - frewsxcv:rollup, r=frewsxcv
46f71a0 
Rollup of 19 pull requests

- Successful merges: #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049, #41062, #41066, #41076, #41085
- Failed merges:
@bors bors merged commit 34cf288 into rust-lang:master Apr 5, 2017
@alexcrichton alexcrichton deleted the stabilize-windows-subsystem branch April 19, 2017 16:05
@raphlinus raphlinus mentioned this pull request Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexcrichton @rust-highfive @liigo @nrc @aturon @bors @frewsxcv