Improve some docs for VecDeque #40949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/libcollections/vec_deque.rs
Outdated
| @@ -1073,7 +1073,7 @@ impl<T> VecDeque<T> { | |||
| } | |||
| } | |||
|
|
|||
| /// Inserts an element first in the sequence. | |||
| /// Prepends an element to the front of the `VecDeque`. | |||
There was a problem hiding this comment.
Preprend means inserting to the front, no?
There was a problem hiding this comment.
For push_back we have this sentence: Appends an element to the back of the VecDeque.
I just mirrored that wording for push_front. :) Do you have a better suggestion?
There was a problem hiding this comment.
Just "prepends an element to the VecDeque".
frewsxcv
added
the
A-docs
|
@bors r+ rollup |
|
📌 Commit 1e2a61d has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 2, 2017
Improve some docs for VecDeque r? @GuillaumeGomez
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 2, 2017
Improve some docs for VecDeque r? @GuillaumeGomez
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
Improve some docs for VecDeque r? @GuillaumeGomez
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
Improve some docs for VecDeque r? @GuillaumeGomez
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
Improve some docs for VecDeque r? @GuillaumeGomez
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 4, 2017
Improve some docs for VecDeque r? @GuillaumeGomez
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 4, 2017
Improve some docs for VecDeque r? @GuillaumeGomez
|
@rfcbot reviewed |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 5, 2017
Improve some docs for VecDeque r? @GuillaumeGomez
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 5, 2017
Improve some docs for VecDeque r? @GuillaumeGomez
bors
added a commit
that referenced
this pull request
Apr 5, 2017
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @GuillaumeGomez