-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up TcpStream example #41526
Clean up TcpStream example #41526
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ rollup |
📌 Commit ca96892 has been approved by |
Clean up TcpStream example Fixes rust-lang#35950
Clean up TcpStream example Fixes rust-lang#35950
Failure:
@bors: r- |
@@ -72,24 +72,23 @@ pub struct TcpStream(net_imp::TcpStream); | |||
/// | |||
/// # Examples | |||
/// | |||
/// ```no_run | |||
/// ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: I removed the no_run
because now that the work is being done inside of process
, which is never called, "running" this code doesn't really do much anyway.
Thanks! @bors: r+ rollup |
📌 Commit 7b7fe9b has been approved by |
Clean up TcpStream example Fixes rust-lang#35950
Clean up TcpStream example Fixes rust-lang#35950
Clean up TcpStream example Fixes rust-lang#35950
Fixes #35950