-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta backports #42182
Beta backports #42182
Conversation
The new messages seem universally better. I think these result because we recognize that we are in an invariant context more often.
This seems both to be a safe, conservative choice, and it sidesteps the cycle in rust-lang#41936. Fixes rust-lang#41936.
Fixes rust-lang#41849. Problem was that evaluating the constant expression required evaluating a trait, which would equate types, which would request variance information, which it would then discard. However, computing the variance information would require determining the type of a field, which would evaluate the constant expression. (This problem will potentially arise *later* as we move to more sophisticated constants, however, where we need to check subtyping. We can tackle that when we come to it.)
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ p=1 |
📌 Commit a30c932 has been approved by |
⌛ Testing commit a30c932 with merge adad643... |
💔 Test failed - status-travis |
Failure in building OpenSSL on macOS.
|
@bors r+ p=1 I went ahead and backported the simple openssl build fix. |
📌 Commit 0566d02 has been approved by |
⌛ Testing commit 0566d02 with merge 2df18ed... |
☀️ Test successful - status-appveyor, status-travis |
Backports of: