Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc changes for assert macros #42469

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Doc changes for assert macros #42469

merged 1 commit into from
Jun 7, 2017

Conversation

citizen428
Copy link
Contributor

See #29381

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@citizen428
Copy link
Contributor Author

citizen428 commented Jun 6, 2017 •
edited
Loading

Oops, forgot to r? @steveklabnik or @GuillaumeGomez.

@rust-highfive rust-highfive assigned steveklabnik and unassigned aturon Jun 6, 2017
@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2017
@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you!

@bors
Copy link
Contributor

bors commented Jun 6, 2017

📌 Commit 867ed2e has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 7, 2017
@frewsxcv
Rollup merge of rust-lang#42469 - citizen428:document-assert-macros, …
7f8467e 
…r=steveklabnik

Doc changes for assert macros

See rust-lang#29381
@frewsxcv frewsxcv mentioned this pull request Jun 7, 2017
Merged
bors added a commit that referenced this pull request Jun 7, 2017
@bors
Auto merge of #42494 - frewsxcv:rollup, r=frewsxcv
f73f675 
Rollup of 7 pull requests

- Successful merges: #42409, #42415, #42429, #42438, #42466, #42469, #42485
- Failed merges:
@bors bors merged commit 867ed2e into rust-lang:master Jun 7, 2017
@citizen428 citizen428 deleted the document-assert-macros branch June 7, 2017 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@citizen428 @rust-highfive @steveklabnik @bors @aturon @arielb1