-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #42494
Rollup of 7 pull requests #42494
Conversation
frewsxcv
commented
Jun 7, 2017
- Successful merges: Better docs #42409, Remove 'elided' from lifetime resolution error #42415, rustc_llvm: re-run build script if config.toml changes #42429, doc rewording #42438, syntax_pos::Symbol should not implement Sync #42466, Doc changes for assert macros #42469, Skip printing for skipped doc tests. #42485
- Failed merges:
Removes 'elided' from lifetime resolution errors Removes 'elided' from relevant error messaging tests
Better docs Working on more doc improvements Edit: done for today
Remove 'elided' from lifetime resolution error Removes 'elided' from lifetime resolution errors Removes 'elided' from relevant error messaging tests This PR resolves rust-lang#29094 r? @Mark-Simulacrum
…hton rustc_llvm: re-run build script if config.toml changes closes rust-lang#35199
syntax_pos::Symbol should not implement Sync Fixes rust-lang#42407
…r=steveklabnik Doc changes for assert macros See rust-lang#29381
…crichton Skip printing for skipped doc tests. Followup to rust-lang#42437 to further reduce noise. r? @alexcrichton
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ p=10 |
📌 Commit 24f48d0 has been approved by |
☀️ Test successful - status-appveyor, status-travis |