Better timestamps in builds #42958
Better timestamps in builds #42958
Conversation
aidanhs
force-pushed
the
aphs-better-stamping
branch
from
7608b0a to
9ddee5f
Compare
| date && curl -s --head https://google.com | grep ^Date: | sed 's/Date: //g' | ||
| - stamp sh -x -c "$RUN_SCRIPT" | ||
| - > | ||
| date && curl -s --head https://google.com | grep ^Date: | sed 's/Date: //g' |
There was a problem hiding this comment.
It'd be good to have a comment here explaining this. I'd also like to note that comparing these two may be hard because of timezones (maybe there's something we can pass to date?).
I also think it may be worth printing this once before we run the script and afterwards -- that way we if we do find a problem, we know whether it happened during the build.
$ date && curl -s --head https://google.com | grep ^Date: | sed 's/Date: //g'
Wed Jun 28 16:24:07 MDT 2017
Wed, 28 Jun 2017 22:24:07 GMT
There was a problem hiding this comment.
I've added a comment, also justifying why timezones don't matter (relative differences give all the info we need).
I'm not confused by you suggesting printing before the script and afterwards - that's what it currently does, per the identical lines above and below the stamp line?
There was a problem hiding this comment.
Ah, yes I missed that it already logs before and after. Looks good to me, thanks for doing this!
aidanhs
force-pushed
the
aphs-better-stamping
branch
from
9ddee5f to
4097ed5
Compare
aidanhs
force-pushed
the
aphs-better-stamping
branch
from
4097ed5 to
984e764
Compare
|
@bors r+ rollup |
|
📌 Commit 984e764 has been approved by |
…k-Simulacrum Better timestamps in builds r? @Mark-Simulacrum
…k-Simulacrum Better timestamps in builds r? @Mark-Simulacrum
r? @Mark-Simulacrum