Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that sort_unstable is deterministic #43374

Merged
merged 1 commit into from Jul 24, 2017
Merged

Clarify that sort_unstable is deterministic #43374

merged 1 commit into from Jul 24, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 20, 2017

@frankmcsherry complained that the documentation said "it is randomized but deterministic", which is a contradictory statement.

This PR uses a different and clearer wording.

@shepmaster
Copy link
Member

Looks like libs team to me... picking r? @brson

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 22, 2017

📌 Commit 9a51055 has been approved by alexcrichton

@Mark-Simulacrum
Copy link
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 24, 2017
…ment, r=alexcrichton

Clarify that sort_unstable is deterministic

@frankmcsherry complained that the documentation said "it is randomized but deterministic", which is a contradictory statement.

This PR uses a different and clearer wording.
bors added a commit that referenced this pull request Jul 24, 2017
Rollup of 11 pull requests

- Successful merges: #43297, #43322, #43342, #43361, #43366, #43374, #43379, #43401, #43421, #43428, #43446
- Failed merges:
@bors bors merged commit 9a51055 into rust-lang:master Jul 24, 2017
@ghost ghost deleted the fix-sort-randomization-comment branch July 24, 2017 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants