Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a missing verb to the description of std::process::ExitStatus::success() #43379

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Add a missing verb to the description of std::process::ExitStatus::success() #43379

merged 1 commit into from
Jul 24, 2017

Conversation

s3rvac
Copy link
Contributor

@s3rvac s3rvac commented Jul 21, 2017

"Signal termination not considered" -> "Signal termination is not considered"

The first line of the description was rewrapped so it fits into 80 characters.

@s3rvac
Add a missing verb to the description of std::process::ExitStatus::su…
3cefd2b 
…ccess().

"Signal termination not considered" -> "Signal termination is not considered"

The first line of the description was rewrapped so it fits into 80 characters.
@shepmaster
Copy link
Member

Looks like docs to me... r? @GuillaumeGomez

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2017
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 21, 2017

📌 Commit 3cefd2b has been approved by GuillaumeGomez

@s3rvac s3rvac closed this Jul 23, 2017
@s3rvac s3rvac deleted the fix-exit-status-success-description branch July 23, 2017 17:19
@s3rvac s3rvac restored the fix-exit-status-success-description branch July 23, 2017 17:20
@s3rvac s3rvac reopened this Jul 23, 2017
@s3rvac
Copy link
Contributor Author

s3rvac commented Jul 23, 2017

Sorry, I have accidentally removed the branch. It is now back.

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 24, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jul 24, 2017

📌 Commit 3cefd2b has been approved by GuillaumeGomez

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 24, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#43379 - s3rvac:fix-exit-status-success-desc…
d1ba747 
…ription, r=GuillaumeGomez

Add a missing verb to the description of std::process::ExitStatus::success()

"Signal termination not considered" -> "Signal termination **is** not considered"

The first line of the description was rewrapped so it fits into 80 characters.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 24, 2017
Merged
bors added a commit that referenced this pull request Jul 24, 2017
@bors
Auto merge of #43454 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
598eddf 
Rollup of 11 pull requests

- Successful merges: #43297, #43322, #43342, #43361, #43366, #43374, #43379, #43401, #43421, #43428, #43446
- Failed merges:
@bors bors merged commit 3cefd2b into rust-lang:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s3rvac @shepmaster @GuillaumeGomez @bors