-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend E0623 for fn items #44516
Extend E0623 for fn items #44516
Changes from 6 commits
2f50c33
ed11812
b2d869d
54af570
a128051
93529b4
6e3cdce
e71eef1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
|
||
fn foo(x: fn(&u8, &u8), y: Vec<&u8>, z: &u8) { | ||
// Debruijn 1 1 1 1 | ||
// Anon-Index 0 1 0 1 | ||
// ------ | ||
// debruijn indices are shifted by 1 in here | ||
y.push(z); // index will be zero or one | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -204,6 +204,13 @@ impl<'a, 'gcx, 'tcx> Visitor<'gcx> for FindNestedTypeVisitor<'a, 'gcx, 'tcx> { | |
|
||
fn visit_ty(&mut self, arg: &'gcx hir::Ty) { | ||
match arg.node { | ||
hir::TyBareFn(_) => { | ||
self.depth += 1; | ||
intravisit::walk_ty(self, arg); | ||
self.depth -= 1; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No such field [00:06:31] error[E0609]: no field `depth` on type `&mut infer::error_reporting::different_lifetimes::FindNestedTypeVisitor<'a, 'gcx, 'tcx>`
[00:06:31] --> /checkout/src/librustc/infer/error_reporting/different_lifetimes.rs:208:22
[00:06:31] |
[00:06:31] 208 | self.depth += 1;
[00:06:31] | ^^^^^
[00:06:31]
[00:06:31] error[E0609]: no field `depth` on type `&mut infer::error_reporting::different_lifetimes::FindNestedTypeVisitor<'a, 'gcx, 'tcx>`
[00:06:31] --> /checkout/src/librustc/infer/error_reporting/different_lifetimes.rs:210:22
[00:06:31] |
[00:06:31] 210 | self.depth -= 1;
[00:06:31] | ^^^^^
[00:06:31]
[00:06:41] error: aborting due to 2 previous errors
[00:06:41]
[00:06:41] error: Could not compile `rustc`. |
||
return; | ||
} | ||
|
||
hir::TyRptr(ref lifetime, _) => { | ||
// the lifetime of the TyRptr | ||
let hir_id = self.infcx.tcx.hir.node_to_hir_id(lifetime.id); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
error[E0623]: lifetime mismatch | ||
--> $DIR/ex3-both-anon-regions-4.rs:12:13 | ||
| | ||
11 | fn foo(z: &mut Vec<(&u8,&u8)>, (x, y): (&u8, &u8)) { | ||
| --- --- these references are declared with different lifetimes... | ||
12 | z.push((x,y)); | ||
| ^ ...but data flows into `z` here | ||
|
||
error[E0623]: lifetime mismatch | ||
--> $DIR/ex3-both-anon-regions-4.rs:12:15 | ||
| | ||
11 | fn foo(z: &mut Vec<(&u8,&u8)>, (x, y): (&u8, &u8)) { | ||
| --- --- these references are declared with different lifetimes... | ||
12 | z.push((x,y)); | ||
| ^ ...but data flows into `z` here | ||
|
||
error: aborting due to 2 previous errors | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
struct Ref<'a, 'b> { | ||
a: &'a u32, | ||
b: &'b u32, | ||
} | ||
|
||
fn foo(mut x: Ref) { | ||
x.a = x.b; | ||
} | ||
|
||
fn main() {} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
error[E0623]: lifetime mismatch | ||
--> $DIR/ex3-both-anon-regions-both-are-structs-4.rs:16:11 | ||
| | ||
15 | fn foo(mut x: Ref) { | ||
| --- | ||
| | | ||
| these two types are declared with different lifetimes... | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test case differs from actual output. error[E0623]: lifetime mismatch
--> $DIR/ex3-both-anon-regions-both-are-structs-4.rs:16:11
|
15 | fn foo(mut x: Ref) {
| ---
| |
- | these two types are declared with different lifetimes...
+ | this type was declared with multiple lifetimes...
16 | x.a = x.b;
| ^^^ ...but data with one lifetime flows into the other here |
||
16 | x.a = x.b; | ||
| ^^^ ...but data with one lifetime flows into the other here | ||
|
||
error: aborting due to previous error | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
struct Ref<'a, 'b> { a: &'a u32, b: &'b u32 } | ||
|
||
fn foo(mut y: Ref, x: &u32) { | ||
y.b = x; | ||
} | ||
|
||
fn main() { } |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
error[E0623]: lifetime mismatch | ||
--> $DIR/ex3-both-anon-regions-one-is-struct-4.rs:14:11 | ||
| | ||
13 | fn foo(mut y: Ref, x: &u32) { | ||
| --- ---- these two types are declared with different lifetimes... | ||
14 | y.b = x; | ||
| ^ ...but data from `x` flows into `y` here | ||
|
||
error: aborting due to previous error | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
fn foo(x:fn(&u8, &u8), y: Vec<&u8>, z: &u8) { | ||
y.push(z); | ||
} | ||
|
||
fn main() { } |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
error[E0623]: lifetime mismatch | ||
--> src/test/ui/lifetime-errors/ex3-both-anon-regions-using-fn-items.rs:11:10 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto error[E0623]: lifetime mismatch
- --> src/test/ui/lifetime-errors/ex3-both-anon-regions-using-fn-items.rs:11:10
+ --> $DIR/ex3-both-anon-regions-using-fn-items.rs:11:10
|
10 | fn foo(x:fn(&u8, &u8), y: Vec<&u8>, z: &u8) {
| --- --- these two types are declared with different lifetimes...
11 | y.push(z);
| ^ ...but data from `z` flows into `y` here
error: aborting due to previous error |
||
| | ||
10 | fn foo(x:fn(&u8, &u8), y: Vec<&u8>, z: &u8) { | ||
| --- --- these two types are declared with different lifetimes... | ||
11 | y.push(z); | ||
| ^ ...but data from `z` flows into `y` here | ||
|
||
error: aborting due to previous error | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you accidentially left this file in the root dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah. I'm open a PR for that or I have an ongoing PR, I'll make sure to delete that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #44549. Thanks!