Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in rustdoc book #45307

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Fix typo in rustdoc book #45307

merged 1 commit into from
Oct 17, 2017

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Oct 15, 2017

There was a tyop :P

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @QuietMisdreavus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2017
@QuietMisdreavus
Copy link
Member

@bors r+ rollup

Haha whoops, nice catch! Thanks!

@bors
Copy link
Contributor

bors commented Oct 15, 2017

📌 Commit b7d378a has been approved by QuietMisdreavus

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2017
@steveklabnik
Copy link
Member

😓 😅 ❤️

@kennytm kennytm mentioned this pull request Oct 17, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Oct 17, 2017
@kennytm
Rollup merge of rust-lang#45307 - dbrgn:fix-typo, r=QuietMisdreavus
6b2027b 
Fix typo in rustdoc book

There was a tyop :P
bors added a commit that referenced this pull request Oct 17, 2017
@bors
Auto merge of #45344 - kennytm:rollup, r=kennytm
f6d7514 
Rollup of 10 pull requests

- Successful merges: #45097, #45151, #45307, #45308, #45310, #45315, #45321, #45329, #45338, #45339
- Failed merges:
@bors bors merged commit b7d378a into rust-lang:master Oct 17, 2017
@dbrgn dbrgn deleted the fix-typo branch December 18, 2017 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dbrgn @rust-highfive @QuietMisdreavus @bors @steveklabnik @kennytm