Rollup of 10 pull requests #45344
Merged
Rollup of 10 pull requests #45344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kennytm
commented
Oct 17, 2017
kennytm
commented
- Successful merges: address more FIXME whose associated issues were marked as closed #45097, Document defaults for stdin, stdout, and stderr methods of Command #45151, Fix typo in rustdoc book #45307, Rustdoc book: Add missing headlines #45308, aarch64 is not whitelisted for ARM features #45310, don't issue "expected statement after outer attr." after inner attr. #45315, ci: Update Travis OSX builders #45321, Remove duplicated word #45329, bootstrap: Avoid fetching jemalloc if it's disabled #45338, Update array documentation for Clone trait changes #45339
- Failed merges:
update FIXME(rust-lang#6298) to point to open issue 15020 update FIXME(rust-lang#6268) to point to RFC 811 update FIXME(rust-lang#10520) to point to RFC 1751 remove FIXME for emscripten issue 4563 and include target in `test_estimate_scaling_factor` remove FIXME(rust-lang#18207) since node_id isn't used for `ref` pattern analysis remove FIXME(rust-lang#6308) since DST was implemented in rust-lang#12938 remove FIXME(rust-lang#2658) since it was decided to not reorganize module remove FIXME(rust-lang#20590) since it was decided to stay conservative with projection types remove FIXME(rust-lang#20297) since it was decided that solving the issue is unnecessary remove FIXME(rust-lang#27086) since closures do correspond to structs now remove FIXME(rust-lang#13846) and enable `function_sections` for windows remove mention of rust-lang#22079 in FIXME(rust-lang#22079) since this is a general FIXME remove FIXME(rust-lang#5074) since the restriction on borrow were lifted
Some options were missing headlines, which looked a bit inconsistent.
While an inner attribute here is in fact erroneous, that error ("inner
attribute is not permitted in this context") successfully gets set earlier;
this further admonition is nonsensical.
Resolves rust-lang#45296.
Looks like Travis [has announced][blog] that our current `xcode8.2` image is being deprecated and the recommended Xcode 7 image is `xcode7.3`. This updates us to these ahead of time to make sure we can shake out any bugs, if any. [blog]: https://blog.travis-ci.com/2017-10-16-a-new-default-os-x-image-is-coming
address more FIXME whose associated issues were marked as closed part of rust-lang#44366
Document defaults for stdin, stdout, and stderr methods of Command For rust-lang#29370
Fix typo in rustdoc book There was a tyop :P
Rustdoc book: Add missing headlines Some options were missing headlines, which looked a bit inconsistent.
aarch64 is not whitelisted for ARM features This prevents the target feature `neon` from being enabled on aarch64.
…_outer_attr_after_inner_attr, r=petrochenkov
don't issue "expected statement after outer attr." after inner attr.
While an inner attribute here is in fact erroneous, that error ("inner
attribute is not permitted in this context") successfully gets set earlier;
this further admonition is nonsensical.
Resolves rust-lang#45296.
ci: Update Travis OSX builders Looks like Travis [has announced][blog] that our current `xcode8.2` image is being deprecated and the recommended Xcode 7 image is `xcode7.3`. This updates us to these ahead of time to make sure we can shake out any bugs, if any. [blog]: https://blog.travis-ci.com/2017-10-16-a-new-default-os-x-image-is-coming
…sdreavus Remove duplicated word r? @rust-lang/docs
bootstrap: Avoid fetching jemalloc if it's disabled Fix rust-lang#45300 More conditions, more madness :) Tested locally.
Update array documentation for Clone trait changes
Just a note, for this to work, `T` doesn't have to `Copy`, `Clone` is sufficient. For instance, the following works.
```rust
fn x(a: &[String; 100]) -> [String; 100] {
a.clone()
}
```
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 |
|
📌 Commit 7f72b31 has been approved by |
kennytm
added
the
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.