Cleanup for libgraphviz #46784
Merged
Cleanup for libgraphviz #46784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
oli-obk
requested changes
Dec 17, 2017
src/libgraphviz/lib.rs
Outdated
| text.push("[shape="); | ||
| text.push(&shape); | ||
| text.push("]"); | ||
| write!(text, "[shape={}]", &s.to_dot_string()); |
src/libgraphviz/lib.rs
Outdated
| } | ||
|
|
||
| text.push(";"); | ||
| writeln(w, &text)?; | ||
| write!(text, ";"); |
src/libgraphviz/lib.rs
Outdated
| let source = g.source(e); | ||
| let target = g.target(e); | ||
| let source_id = g.node_id(&source); | ||
| let target_id = g.node_id(&target); | ||
|
|
||
| let mut text = vec![source_id.as_slice(), " -> ", target_id.as_slice()]; | ||
| let mut text = ::std::io::Cursor::new(Vec::new()); |
There was a problem hiding this comment.
Are cursors necessary? Can't you write to vecs directly?
There was a problem hiding this comment.
Didn't know you could write to them without cursor.
kennytm
added
the
S-waiting-on-review
|
As it can't fail. (Its on the |
oli-obk
reviewed
Dec 17, 2017
src/libgraphviz/lib.rs
Outdated
| text.push(";"); | ||
| writeln(w, &text)?; | ||
| write!(text, ";").unwrap(); | ||
| w.write_all(&text[..])?; |
There was a problem hiding this comment.
This change removes a newline, which breaks some tests
oli-obk
approved these changes
Dec 18, 2017
|
Rebased |
pnkfelix
reviewed
Dec 21, 2017
| for n in g.nodes().iter() { | ||
| indent(w)?; | ||
| write!(w, " ")?; |
There was a problem hiding this comment.
(personally I usually prefer a function like indent over having to double-check that the string contents all match up, but since there are only two calls to indent I'm not going to make a fuss)
|
@bors r+ rollup |
|
📌 Commit 2e2defd has been approved by |
pnkfelix
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 21, 2017
Cleanup for libgraphviz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.