Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcore/num/mod.rs: simplify the int_impl! macro. #46820

Merged
merged 1 commit into from
Dec 22, 2017
Merged

libcore/num/mod.rs: simplify the int_impl! macro. #46820

merged 1 commit into from
Dec 22, 2017

Conversation

nodakai
Copy link
Contributor

@nodakai nodakai commented Dec 18, 2017

We can simply use generic intrinsics since cd1848a by @alexcrichton

Also, minimize unsafe blocks.

@nodakai
libcore/num/mod.rs: simplify the int_impl! macro.
6bce6ac 
We can simply use generic intrinsics since cd1848a

Also, minimize unsafe blocks.

Signed-off-by: NODA, Kai <nodakai@gmail.com>
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 18, 2017

📌 Commit 6bce6ac has been approved by alexcrichton

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 19, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Dec 21, 2017
@kennytm
Rollup merge of rust-lang#46820 - nodakai:simplify-int-impl, r=alexcr…
dc00aa4 
…ichton

libcore/num/mod.rs: simplify the int_impl! macro.

We can simply use generic intrinsics since cd1848a by @alexcrichton

Also, minimize unsafe blocks.
@kennytm kennytm mentioned this pull request Dec 21, 2017
Merged
bors added a commit that referenced this pull request Dec 21, 2017
@bors
Auto merge of #46922 - kennytm:rollup, r=kennytm
ba27415 
Rollup of 14 pull requests

- Successful merges: #46636, #46780, #46784, #46809, #46814, #46820, #46839, #46847, #46858, #46878, #46884, #46890, #46898, #46918
- Failed merges:
@bors bors merged commit 6bce6ac into rust-lang:master Dec 22, 2017
@nodakai nodakai deleted the simplify-int-impl branch December 22, 2017 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodakai @alexcrichton @bors @kennytm