-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: use {U,I}size instead of {U,I}s shorthands. #47170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems fine, but it surprises me to see any change in behavior due to it...?
@@ -11,18 +11,24 @@ error[E0606]: casting `&[i32]` as `isize` is invalid | |||
| | |||
21 | a as isize; //~ ERROR casting | |||
| ^^^^^^^^^^ | |||
| | |||
= help: cast through a raw pointer first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happened here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I see now
@bors r+ |
📌 Commit 210ac01 has been approved by |
rustc: use {U,I}size instead of {U,I}s shorthands. `Us`/`Is` come from a time when `us` and `is` were the literal suffixes that are now `usize` / `isize`. r? @nikomatsakis
Us
/Is
come from a time whenus
andis
were the literal suffixes that are nowusize
/isize
.r? @nikomatsakis