miri: use AllocId instead of u64. #47205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
|
Ha. That was on my list. Thanks for doing it. Lgtm |
|
@bors delegate=oli-obk |
|
✌️ @oli-obk can now approve this pull request |
oli-obk
approved these changes
Jan 5, 2018
| /// | ||
| /// The pointers are to the beginning of an `alloc_by_id` allocation | ||
| alloc_cache: FxHashMap<interpret::GlobalId<'tcx>, interpret::Pointer>, | ||
| alloc_cache: FxHashMap<interpret::GlobalId<'tcx>, interpret::AllocId>, |
There was a problem hiding this comment.
The idea was that you could have globals which are located inside other locals in the future. So if a constant's value is obtained by indexing another constant, we'd just point to the offset in the array constant.
There was a problem hiding this comment.
We do need miri allocations properly exposed for miri alloc -> LLVM global translation, or at least some guarantee that statics don't get optimized like that.
FWIW I think MemoryPointer would be a better fit, eventually.
|
@bors r+ Maybe bors doesn't like reviews? |
|
📌 Commit 0907494 has been approved by |
kennytm
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes @alexreg's miri allocation -> LLVM global translation more straight-forward.
r? @oli-obk