Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up SVH computation by using Fingerprint::combine() #48966

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Speed up SVH computation by using Fingerprint::combine() #48966

merged 1 commit into from
Mar 14, 2018

Conversation

hrvolapeter
Copy link
Member

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2018
michaelwoerister
michaelwoerister reviewed Mar 12, 2018
View reviewed changes
src/librustc/hir/map/collector.rs Outdated
(def_path_hash, self.dep_graph.fingerprint_of(dep_node_index))
})
.collect();
.to_vec();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_vec() will copy the whole vector. However, since we take self by value here, we can safely modify it in place. If you declare self mutable, then you should be able to do the following:

self.hir_body_nodes.sort_unstable_by(|&(ref d1, _), &(ref d2, _)| d1.cmp(d2));
let node_hashes = self.hir_body_nodes
    .iter()
    ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for review, I was not sure if it won't brake anything. However, modifying hir_body_nodes itself will make the code a lot faster.

@michaelwoerister
Copy link
Member

Thanks for the PR, @retep007!

@michaelwoerister michaelwoerister added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2018
@hrvolapeter
Copy link
Member Author

fixed

r? @michaelwoerister

@michaelwoerister
Copy link
Member

Thanks, @retep007!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 14, 2018

📌 Commit 2f2e173 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2018
@kennytm kennytm mentioned this pull request Mar 14, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 14, 2018
@kennytm
Rollup merge of rust-lang#48966 - retep007:hir-fingerprint-optimizati…
6639b60 
…on, r=michaelwoerister

Speed up SVH computation by using Fingerprint::combine()

Fix rust-lang#47297
bors added a commit that referenced this pull request Mar 14, 2018
@bors
Auto merge of #49008 - kennytm:rollup, r=kennytm
521d91c 
Rollup of 12 pull requests

- Successful merges: #48765, #48831, #48840, #48964, #48970, #48971, #48981, #48988, #48991, #48966, #48993, #48874
- Failed merges:
@bors bors merged commit 2f2e173 into rust-lang:master Mar 14, 2018
@hrvolapeter hrvolapeter deleted the hir-fingerprint-optimization branch March 16, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelwoerister michaelwoerister michaelwoerister left review comments

Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hrvolapeter @rust-highfive @michaelwoerister @bors