Add a test for #48070 #48988
Merged
Add a test for #48070 #48988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves rust-lang#48070. The bug itself was fixed by rust-lang#48770, but that PR didn't add a test for it.
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
requested changes
Mar 13, 2018
src/test/run-pass/issue-48070.rs
Outdated
| @@ -0,0 +1,34 @@ | |||
| // Copyright 2018 The Rust Project Developers. See the COPYRIGHT | |||
There was a problem hiding this comment.
can you rename this file to run-pass/nll/issue-48070.rs?
Or, better yet, ui/nll/issue-48070.rs? (In that case, you would add a // run-pass comment in the header)
|
I have moved the test to |
|
@bors r+ rollup |
|
📌 Commit 52bb99d has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 14, 2018
…atsakis Add a test for rust-lang#48070 Resolves rust-lang#48070. The bug itself was fixed by rust-lang#48770, but that PR didn't add a test for it. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48070.
The bug itself was fixed by #48770, but that PR didn't add a test for it.
r? @nikomatsakis