-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automatic urls with backticks #49189
Merged
alexcrichton
merged 1 commit into
rust-lang:master
from
GuillaumeGomez:fix-implied-shortcut-links
Mar 22, 2018
Merged
Fix automatic urls with backticks #49189
alexcrichton
merged 1 commit into
rust-lang:master
from
GuillaumeGomez:fix-implied-shortcut-links
Mar 22, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Mar 19, 2018
QuietMisdreavus
approved these changes
Mar 20, 2018
continue; | ||
} | ||
let (def, fragment) = { | ||
let link = ori_link.replace("`", ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some part of me wants this to be a trim_matches
instead of a replace
, but in practice it won't matter.
@bors r+ rollup |
📌 Commit bac6484 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 20, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 21, 2018
…-links, r=QuietMisdreavus Fix automatic urls with backticks Fixes rust-lang#49164. r? @QuietMisdreavus
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 22, 2018
…-links, r=QuietMisdreavus Fix automatic urls with backticks Fixes rust-lang#49164. r? @QuietMisdreavus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49164.
r? @QuietMisdreavus