Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic urls with backticks #49189

Merged

Conversation

GuillaumeGomez
Copy link
Member

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2018
continue;
}
let (def, fragment) = {
let link = ori_link.replace("`", "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some part of me wants this to be a trim_matches instead of a replace, but in practice it won't matter.

@QuietMisdreavus
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 20, 2018

📌 Commit bac6484 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 21, 2018
…-links, r=QuietMisdreavus

Fix automatic urls with backticks

Fixes rust-lang#49164.

r? @QuietMisdreavus
kennytm added a commit to kennytm/rust that referenced this pull request Mar 22, 2018
…-links, r=QuietMisdreavus

Fix automatic urls with backticks

Fixes rust-lang#49164.

r? @QuietMisdreavus
bors added a commit that referenced this pull request Mar 22, 2018
@alexcrichton alexcrichton merged commit bac6484 into rust-lang:master Mar 22, 2018
@GuillaumeGomez GuillaumeGomez deleted the fix-implied-shortcut-links branch March 23, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants