Implement Chalk lowering rule "Implemented-From-Env" #49211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the Chalk lowering pass with the "Implemented-From-Env" rule for generating program clauses from a trait definition as part of rust-lang#49177.
pietroalbini
added
the
S-waiting-on-review
11 tasks
nikomatsakis
approved these changes
Mar 20, 2018
| let where_clauses = tcx.predicates_of(def_id).predicates.lower(); | ||
|
|
||
| let clause = Clause::Implies(where_clauses, trait_ref); | ||
| // `Implemented(A0: Trait<A1..An>) :- WC` | ||
| let clause = Clause::Implies(where_clauses, trait_pred); |
There was a problem hiding this comment.
leave the code better than you found it. I like it.
|
@bors r+ rollup |
|
📌 Commit 7791995 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 21, 2018
…rom-Env, r=nikomatsakis Implement Chalk lowering rule "Implemented-From-Env" This extends the Chalk lowering pass with the "Implemented-From-Env" rule for generating program clauses from a trait definition as part of rust-lang#49177. r? @nikomatsakis
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 22, 2018
…rom-Env, r=nikomatsakis Implement Chalk lowering rule "Implemented-From-Env" This extends the Chalk lowering pass with the "Implemented-From-Env" rule for generating program clauses from a trait definition as part of rust-lang#49177. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the Chalk lowering pass with the "Implemented-From-Env" rule for generating program clauses from a trait definition as part of #49177.
r? @nikomatsakis