Stabilize impl Trait #49255

cramertj · 2018-03-22T01:42:09Z

Blocked on:

Detect illegal hidden lifetimes in impl Trait #49041 and
completion of FCP in Tracking issue for impl Trait (RFC 1522, RFC 1951, RFC 2071) #34511 (comment) (3 days from now).

I have not yet done any docs work for this-- I probably won't get to it until this weekend (might be a project for the flight to the all-hands).

rust-highfive · 2018-03-22T01:42:19Z

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

cramertj · 2018-03-22T01:46:48Z

r? @nikomatsakis

cramertj · 2018-03-22T07:06:25Z

Also-- miri and clippy both used conservative_impl_trait internally. I removed those locally, but I'm not sure of the right way to update those submodules atomically w/ the feature removal.

nikomatsakis · 2018-03-22T15:54:10Z

With respect to docs, @steveklabnik plans to file an RFC changing process there somewhat in any case.

nikomatsakis · 2018-03-22T15:56:27Z

src/libsyntax/feature_gate.rs

+    // Allows `impl Trait` in function arguments.
+    (accepted, universal_impl_trait, "1.26.0", Some(34511), None),
+    // Allows `impl Trait` in function return types.
+    (accepted, conservative_impl_trait, "1.26.0", Some(34511), None),


wowoow... finally.

nikomatsakis · 2018-03-22T16:25:19Z

@bors r+

The FCP is not yet complete, but it's hard to imagine what would cause us to reverse course here, and in any case we can always backport a patch to beta reversing course or fixing things up.

bors · 2018-03-22T16:25:21Z

📌 Commit d818194 has been approved by nikomatsakis

nikomatsakis · 2018-03-22T16:25:54Z

(cc @Manishearth and @oli-obk for clippy/miri respectively)

Manishearth · 2018-03-22T16:31:24Z

@cramertj we'll just update, thanks.

The best way to do it is to throw us a PR. even better is to update rustc to point to the commit in the PR so we don't need to come back and do that. But you don't have to.

kennytm · 2018-03-22T16:36:32Z

mark-i-m · 2018-03-22T21:14:47Z

1.26 is going to be a really exciting release. We already have i128 and ..= in there...

cramertj · 2018-03-22T22:43:07Z

@mark-i-m And !-type, and probably dyn and match_default_bindings, slice patterns...

mark-i-m · 2018-03-23T02:13:46Z

Woah what really!? 🎉

kennytm · 2018-03-23T02:56:44Z

Confirmed stabilized:

Option<&mut T>::cloned()
LocalKey::try_with (for thread-local storage)
slice pattern (match x { &[y, z] => w, ... })
[T]::rotate_left and [T]::rotate_right
The Book 2nd edition
--remap-path-prefix
<*T>::add, <*T>::copy_nonoverlapping, etc
Box::leak
inclusive range (..=)
never type (!)
FusedIterator
format!("{:02x?}", [0x41, 0x42, 0x43])
closures will derive Copy and Clone

Scheduled to be stabilized:

~~i128~~ (likely can't make it 😞)
impl Trait

I'm not quite sure if dyn and match_default_bindings can make it, as 1.26 is going to enter beta on March 27th (Tuesday). We could keep 1.27 exciting??? 😄

mark-i-m · 2018-03-23T03:15:24Z

Lol @nrc is this boring enough for you :)

SimonSapin · 2018-03-23T13:44:40Z

Reviewers! Help me add to that list ;)

Copy and Clone for closures Stabilize the copy_closures and clone_closures features #49299
TryFrom and TryInto Stabilize TryFrom / TryInto, and tweak impls for integers #49305

…atsakis Stabilize impl Trait Blocked on: - [x] rust-lang#49041 and - [ ] completion of FCP in rust-lang#34511 (comment) (3 days from now). I have not yet done any docs work for this-- I probably won't get to it until this weekend (might be a project for the flight to the all-hands).

bors · 2018-03-24T16:00:40Z

☔ The latest upstream changes (presumably #49251) made this pull request unmergeable. Please resolve the merge conflicts.

cramertj · 2018-03-26T07:43:40Z

@bors r-

need to update lockfile first, perhaps? will test locally

cramertj · 2018-03-26T07:57:26Z

@bors r=nikomatsakis p=100

bors · 2018-03-26T07:57:26Z

📌 Commit c3e2961 has been approved by nikomatsakis

cramertj · 2018-03-26T08:41:52Z

@bors r-

cramertj · 2018-03-26T08:43:31Z

@bors r=nikomatsakis p=100

bors · 2018-03-26T08:43:32Z

📌 Commit 0f5b52e has been approved by nikomatsakis

bors · 2018-03-26T09:14:32Z

⌛ Testing commit 0f5b52e with merge 5e4603f...

Stabilize impl Trait Blocked on: - [x] #49041 and - [ ] completion of FCP in #34511 (comment) (3 days from now). I have not yet done any docs work for this-- I probably won't get to it until this weekend (might be a project for the flight to the all-hands).

bors · 2018-03-26T11:52:56Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 5e4603f to master...

rust-highfive assigned michaelwoerister Mar 22, 2018

cramertj changed the title ~~Stable impl trait~~ Stabilize impl trait Mar 22, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2018

cramertj changed the title ~~Stabilize impl trait~~ Stabilize impl Trait Mar 22, 2018

rust-highfive assigned nikomatsakis and unassigned michaelwoerister Mar 22, 2018

nikomatsakis reviewed Mar 22, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2018

kennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 22, 2018

messense mentioned this pull request Mar 23, 2018

Compile with stable Rust rwf2/Rocket#19

Closed

11 tasks

sinkuu mentioned this pull request Mar 23, 2018

Rustdoc support for universal_impl_trait #49304

Merged

kennytm mentioned this pull request Mar 24, 2018

Rollup of 21 pull requests #49325

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2018

cramertj force-pushed the stable-impl-trait branch from 37f2de9 to c3e2961 Compare March 26, 2018 07:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2018

Stabilize conservative_impl_trait

0f5b52e

cramertj force-pushed the stable-impl-trait branch from c3e2961 to 0f5b52e Compare March 26, 2018 08:43

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2018

bors merged commit 0f5b52e into rust-lang:master Mar 26, 2018

This was referenced Mar 26, 2018

rustbuild: Fail the build if we build Cargo twice #49053

Merged

Stabilize 128-bit integers 🎉 #49101

Merged

WIP: Parallelize passes using rayon #46564

Closed

cramertj deleted the stable-impl-trait branch March 26, 2018 11:58

sunchao mentioned this pull request May 11, 2018

Compile with stable Rust sunchao/parquet-rs#119

Open

5 tasks

FranklinChen mentioned this pull request Jun 3, 2018

FAQ: update information on returning closures rust-lang/prev.rust-lang.org#1121

Open

rodrimati1992 mentioned this pull request Nov 23, 2020

README is wrong about when impl Trait was stabilized. Peternator7/strum#139

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize impl Trait #49255

Stabilize impl Trait #49255

cramertj commented Mar 22, 2018 •

edited

Loading

rust-highfive commented Mar 22, 2018

cramertj commented Mar 22, 2018

cramertj commented Mar 22, 2018

nikomatsakis commented Mar 22, 2018

nikomatsakis Mar 22, 2018

00imvj00 Mar 23, 2018

nikomatsakis commented Mar 22, 2018

bors commented Mar 22, 2018

nikomatsakis commented Mar 22, 2018 •

edited

Loading

Manishearth commented Mar 22, 2018

kennytm commented Mar 22, 2018

mark-i-m commented Mar 22, 2018

cramertj commented Mar 22, 2018

mark-i-m commented Mar 23, 2018

kennytm commented Mar 23, 2018 •

edited

Loading

mark-i-m commented Mar 23, 2018

SimonSapin commented Mar 23, 2018

bors commented Mar 24, 2018

cramertj commented Mar 26, 2018 •

edited

Loading

cramertj commented Mar 26, 2018

bors commented Mar 26, 2018

cramertj commented Mar 26, 2018

cramertj commented Mar 26, 2018

bors commented Mar 26, 2018

bors commented Mar 26, 2018

bors commented Mar 26, 2018

Stabilize impl Trait #49255

Stabilize impl Trait #49255

Conversation

cramertj commented Mar 22, 2018 • edited Loading

rust-highfive commented Mar 22, 2018

cramertj commented Mar 22, 2018

cramertj commented Mar 22, 2018

nikomatsakis commented Mar 22, 2018

nikomatsakis Mar 22, 2018

Choose a reason for hiding this comment

00imvj00 Mar 23, 2018

Choose a reason for hiding this comment

nikomatsakis commented Mar 22, 2018

bors commented Mar 22, 2018

nikomatsakis commented Mar 22, 2018 • edited Loading

Manishearth commented Mar 22, 2018

kennytm commented Mar 22, 2018

mark-i-m commented Mar 22, 2018

cramertj commented Mar 22, 2018

mark-i-m commented Mar 23, 2018

kennytm commented Mar 23, 2018 • edited Loading

mark-i-m commented Mar 23, 2018

SimonSapin commented Mar 23, 2018

bors commented Mar 24, 2018

cramertj commented Mar 26, 2018 • edited Loading

cramertj commented Mar 26, 2018

bors commented Mar 26, 2018

cramertj commented Mar 26, 2018

cramertj commented Mar 26, 2018

bors commented Mar 26, 2018

bors commented Mar 26, 2018

bors commented Mar 26, 2018

cramertj commented Mar 22, 2018 •

edited

Loading

nikomatsakis commented Mar 22, 2018 •

edited

Loading

kennytm commented Mar 23, 2018 •

edited

Loading

cramertj commented Mar 26, 2018 •

edited

Loading