Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 21 pull requests #49325

Closed
wants to merge 70 commits into from
Closed

Rollup of 21 pull requests #49325

wants to merge 70 commits into from

Conversation

Maxwell Powlison and others added 30 commits March 16, 2018 03:41
…l exclusion

The methods on the structures `fs::FileType` and `fs::Metadata` of (respectively) `is_file`, `is_dir`, and
`is_symlink` had some ambiguity in documentation, where it was not noted whether files will pass those tests
exclusively or not. It is now written that the tests are mutually exclusive.

Fixes rust-lang#48345.
This commit tweaks where timing and step information is printed out as part of
the build, ensuring that we do it as close to the location where work happens as
possible. In rustbuild various functions may perform long blocking work as
dependencies are assembled, so if we print out timing information early on we
may accidentally time more than just the step we were intending to time!
LLVM seems to still put the assume calls in when inlining, so this probably isn't in a place where it can be turned on by default, but it's interesting to experiment with.

For example, this makes `swap::<u64x8>` be 8x `vmovaps	ymm` instead of 16x `vmovups	xmm`, on my cpu.
This stabilizes `main` with non-() return types; see rust-lang#48453.
This removes 10 dependencies from the build 🎉
kennytm added 5 commits March 24, 2018 21:22
…lexcrichton

Remove getopts leftover from tree

This was attempted but left incomplete in PR rust-lang#42664, where only the toml
file was removed.

cc @alexcrichton
…, r=nikomatsakis

Stabilize termination_trait, split out termination_trait_test

For rust-lang#48453.

First time contribution, so I'd really appreciate any feedback on how this PR can be better.

Not sure exactly what kind of documentation update is needed. If there is no PR to update the reference, I can try doing that this week as I have time.
…docfix, r=bluss

Fix Issue rust-lang#48345, is_file, is_dir, and is_symlink note mutual exclusion

The methods on the structures `fs::FileType` and `fs::Metadata` of (respectively) `is_file`, `is_dir`, and `is_symlink` had some ambiguity in documentation, where it was not noted whether files will pass those tests exclusively or not. It is now written that the tests are mutually exclusive.

Fixes rust-lang#48345.
Make resuming generators unsafe instead of the creation of immovable generators

Fixes rust-lang#47787
@kennytm kennytm changed the title Rollup of 15 pull requests Rollup of 16 pull requests Mar 24, 2018
@kennytm
Copy link
Member Author

kennytm commented Mar 24, 2018

@bors r+

Removed #49101 (tidy failed), #49203 (merge conflict)
Added #49162, #49076, #49194

@bors
Copy link
Contributor

bors commented Mar 24, 2018

📌 Commit 85abb05 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2018
…ug, r=steveklabnik

Document format_args! / Arguments<'a> behavior wrt. Display and Debug

This is a follow up PR to rust-lang#49067 , this documents the behavior of `format_args!` (i.e: `Argument<'a>`) wrt. `Display` and `Debug`.
@kennytm kennytm changed the title Rollup of 16 pull requests Rollup of 17 pull requests Mar 24, 2018
@kennytm
Copy link
Member Author

kennytm commented Mar 24, 2018

@bors r+

Added #49229, #49046

@bors
Copy link
Contributor

bors commented Mar 24, 2018

📌 Commit 175595a has been approved by kennytm

Always print `aborting due to n previous error(s)`
@kennytm kennytm changed the title Rollup of 17 pull requests Rollup of 18 pull requests Mar 24, 2018
@bors
Copy link
Contributor

bors commented Mar 24, 2018

📌 Commit 0acfcb8 has been approved by kennytm

kennytm added 3 commits March 24, 2018 23:10
…atsakis

Stabilize impl Trait

Blocked on:

- [x] rust-lang#49041 and
- [ ] completion of FCP in rust-lang#34511 (comment) (3 days from now).

I have not yet done any docs work for this-- I probably won't get to it until this weekend (might be a project for the flight to the all-hands).
Stabilize the copy_closures and clone_closures features

In addition to the `Fn*` family of traits, closures now implement `Copy` (and similarly `Clone`) if all of the captures do.

Tracking issue: rust-lang#44490
… r=Mark-Simulacrum

Bump racer and home

This removes 10 dependencies from the build 🎉
@kennytm kennytm changed the title Rollup of 18 pull requests Rollup of 21 pull requests Mar 24, 2018
@kennytm
Copy link
Member Author

kennytm commented Mar 24, 2018

@bors r+

Added #49255, #49299, #49203

I've got meld fixed ☺️

@bors
Copy link
Contributor

bors commented Mar 24, 2018

📌 Commit f34d4f6 has been approved by kennytm

@bors
Copy link
Contributor

bors commented Mar 24, 2018

☔ The latest upstream changes (presumably #49251) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 24, 2018
@kennytm
Copy link
Member Author

kennytm commented Mar 24, 2018

Will create a new one.

@kennytm kennytm closed this Mar 24, 2018
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.