hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros #51762

petrochenkov · 2018-06-24T17:45:34Z

Fixes #50050

rust-highfive · 2018-06-24T17:45:38Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2018-06-24T17:45:44Z

r? @oli-obk

petrochenkov · 2018-06-24T17:46:42Z

This needs a check-only crater run.
ping @rust-lang/infra

petrochenkov · 2018-06-24T18:49:20Z

@bors try

bors · 2018-06-24T18:49:30Z

⌛ Trying commit 6821df083b3c48a629e7d2750afbaea3304a91ea with merge d20562b7ebf6ba2344a2b578710440deee3a92bb...

rust-highfive · 2018-06-24T19:05:42Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-06-24T20:39:18Z

☀️ Test successful - status-travis
State: approved= try=True

petrochenkov · 2018-06-24T22:53:59Z

CI failure fixed.
@bors try

bors · 2018-06-24T22:54:10Z

⌛ Trying commit 463033f with merge f329991...

hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros Fixes #50050

rust-highfive · 2018-06-24T22:55:59Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:45] sha256:8c1f0882640438d1d5e0c0acc857fedd1a16de0d9ee943660aa40de5c9b49bad
[00:00:45] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/x86_64-gnu-llvm-3.9/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:00:46] Sending build context to Docker daemon  501.2kB
[00:00:46] Step 1/6 : FROM ubuntu:16.04
[00:00:46] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:47] Sending build context to Docker daemon  501.2kB
[00:00:47] Step 1/6 : FROM ubuntu:16.04
[00:00:47] Step 1/6 : FROM ubuntu:16.04
[00:00:47] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:49] Sending build context to Docker daemon  501.2kB
[00:00:49] Step 1/6 : FROM ubuntu:16.04
[00:00:49] Step 1/6 : FROM ubuntu:16.04
[00:00:50] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:53] Sending build context to Docker daemon  501.2kB
[00:00:53] Step 1/6 : FROM ubuntu:16.04
[00:00:53] Step 1/6 : FROM ubuntu:16.04
[00:00:53] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:57] Sending build context to Docker daemon  501.2kB
[00:00:57] Step 1/6 : FROM ubuntu:16.04
[00:00:57] Step 1/6 : FROM ubuntu:16.04
[00:00:57] Get https://registry-1.docker.io/v2/library/ubuntu/manifests/16.04: received unexpected HTTP status: 503 Service Unavailable
[00:00:57] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:0133555e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:00cc2430:start=1529880927451103207,finish=1529880927459145405,duration=8042198
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:029acca7
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:28d9b87e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-06-24T22:59:09Z

💔 Test failed - status-travis

rust-highfive · 2018-06-24T22:59:10Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:16f4cbf2
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
[00:02:48] sha256:eba3207fbb3ce77a32cf11eef774aad9cc65b9ec6ae26d793a0401552a2ad164
[00:02:48] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/dist-x86_64-linux/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:02:48] Sending build context to Docker daemon  501.2kB
[00:02:48] Step 1/38 : FROM centos:5
[00:02:48] Get https://registry-1.docker.io/v2/library/centos/manifests/5: received unexpected HTTP status: 503 Service Unavailable
[00:02:49] Sending build context to Docker daemon  501.2kB
[00:02:49] Step 1/38 : FROM centos:5
[00:02:49] Step 1/38 : FROM centos:5
[00:02:49] Get https://registry-1.docker.io/v2/library/centos/manifests/5: received unexpected HTTP status: 503 Service Unavailable
[00:02:52] Sending build context to Docker daemon  501.2kB
[00:02:52] Step 1/38 : FROM centos:5
[00:02:52] Step 1/38 : FROM centos:5
[00:02:52] Get https://registry-1.docker.io/v2/library/centos/manifests/5: received unexpected HTTP status: 503 Service Unavailable
[00:02:55] Sending build context to Docker daemon  501.2kB
[00:02:55] Step 1/38 : FROM centos:5
[00:02:55] Step 1/38 : FROM centos:5
[00:02:55] Get https://registry-1.docker.io/v2/library/centos/manifests/5: received unexpected HTTP status: 503 Service Unavailable
[00:03:00] Sending build context to Docker daemon  501.2kB
[00:03:00] Step 1/38 : FROM centos:5
[00:03:00] Step 1/38 : FROM centos:5
[00:03:00] Get https://registry-1.docker.io/v2/library/centos/manifests/5: received unexpected HTTP status: 503 Service Unavailable
[00:03:00] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:1272c24c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:275775d8:start=1529881104034637768,finish=1529881104041701127,duration=7063359
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:060d32dc
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:04e14872
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-24T22:59:11Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:16f4cbf2
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
[00:02:48] sha256:eba3207fbb3ce77a32cf11eef774aad9cc65b9ec6ae26d793a0401552a2ad164
[00:02:48] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/dist-x86_64-linux/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:02:48] Sending build context to Docker daemon  501.2kB
[00:02:48] Step 1/38 : FROM centos:5
[00:02:48] Get https://registry-1.docker.io/v2/library/centos/manifests/5: received unexpected HTTP status: 503 Service Unavailable
[00:02:49] Sending build context to Docker daemon  501.2kB
[00:02:49] Step 1/38 : FROM centos:5
[00:02:49] Step 1/38 : FROM centos:5
[00:02:49] Get https://registry-1.docker.io/v2/library/centos/manifests/5: received unexpected HTTP status: 503 Service Unavailable
[00:02:52] Sending build context to Docker daemon  501.2kB
[00:02:52] Step 1/38 : FROM centos:5
[00:02:52] Step 1/38 : FROM centos:5
[00:02:52] Get https://registry-1.docker.io/v2/library/centos/manifests/5: received unexpected HTTP status: 503 Service Unavailable
[00:02:55] Sending build context to Docker daemon  501.2kB
[00:02:55] Step 1/38 : FROM centos:5
[00:02:55] Step 1/38 : FROM centos:5
[00:02:55] Get https://registry-1.docker.io/v2/library/centos/manifests/5: received unexpected HTTP status: 503 Service Unavailable
[00:03:00] Sending build context to Docker daemon  501.2kB
[00:03:00] Step 1/38 : FROM centos:5
[00:03:00] Step 1/38 : FROM centos:5
[00:03:00] Get https://registry-1.docker.io/v2/library/centos/manifests/5: received unexpected HTTP status: 503 Service Unavailable
[00:03:00] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:1272c24c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:275775d8:start=1529881104034637768,finish=1529881104041701127,duration=7063359
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:060d32dc
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:04e14872
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexreg · 2018-06-25T00:15:58Z

@petrochenkov Looks like this will be relevant to my PR #47992? (I still need to write up the RFC for this, I know.)

oli-obk · 2018-06-25T08:40:31Z

@bors try

kennytm · 2018-06-25T08:45:38Z

@bors retry

bors · 2018-06-25T08:45:50Z

⌛ Trying commit 463033f with merge d3e0caee31f4e75324933a49a572998329636aa3...

petrochenkov · 2018-06-29T23:44:50Z

@bors r=oli-obk

bors · 2018-06-29T23:44:51Z

📌 Commit 84f1bc8 has been approved by oli-obk

hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros Fixes rust-lang#50050

bors · 2018-06-30T06:06:18Z

⌛ Testing commit 84f1bc8 with merge 9f38556c4269eefcfacd639e8ace056a20891aaf...

bors · 2018-06-30T07:10:15Z

💔 Test failed - status-travis

rust-highfive · 2018-06-30T07:10:16Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

  0     0    0     0    0     0      0      0 --:--:--  0:00:51 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:52 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:53 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:54 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:55 --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:00:16] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:589:17
[01:00:16] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --no-fail-fast src/doc/book src/doc/nomicon src/doc/reference src/doc/rust-by-example src/tools/rls src/tools/rustfmt src/tools/miri src/tools/clippy
[01:00:16] Build completed unsuccessfully in 0:57:32
[01:00:16] {"rustfmt":"test-pass","miri":"test-pass","nomicon":"test-pass","reference":"test-pass","clippy-driver":"test-pass","rust-by-example":"test-pass","rls":"test-pass","book":"test-pass"}
[01:00:16] Verifying status of book...
---
travis_time:end:036a89c4:start=1530342558755635863,finish=1530342558763016171,duration=7380308
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0935c967
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2a73e396
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-30T07:10:21Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

  0     0    0     0    0     0      0      0 --:--:--  0:00:51 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:52 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:53 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:54 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:55 --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:00:16] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:589:17
[01:00:16] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --no-fail-fast src/doc/book src/doc/nomicon src/doc/reference src/doc/rust-by-example src/tools/rls src/tools/rustfmt src/tools/miri src/tools/clippy
[01:00:16] Build completed unsuccessfully in 0:57:32
[01:00:16] {"rustfmt":"test-pass","miri":"test-pass","nomicon":"test-pass","reference":"test-pass","clippy-driver":"test-pass","rust-by-example":"test-pass","rls":"test-pass","book":"test-pass"}
[01:00:16] Verifying status of book...
---
travis_time:end:036a89c4:start=1530342558755635863,finish=1530342558763016171,duration=7380308
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0935c967
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2a73e396
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-06-30T07:16:21Z

@bors retry travis-ci/travis-ci#9696

bors · 2018-06-30T09:19:27Z

⌛ Testing commit 84f1bc8 with merge bfc1ee4...

hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros Fixes #50050

bors · 2018-06-30T11:26:45Z

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing bfc1ee4 to master...

rust-highfive assigned aturon Jun 24, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2018

rust-highfive assigned oli-obk and unassigned aturon Jun 24, 2018

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2018

petrochenkov mentioned this pull request Jun 24, 2018

TokenStream::parse does not resolve with Span::call_site() #50050

Closed

petrochenkov force-pushed the oh-hi-mark branch from 6821df0 to 463033f Compare June 24, 2018 22:53

bors added a commit that referenced this pull request Jun 24, 2018

Auto merge of #51762 - petrochenkov:oh-hi-mark, r=<try>

f329991

hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros Fixes #50050

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 24, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2018

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 30, 2018

Rollup merge of rust-lang#51762 - petrochenkov:oh-hi-mark, r=oli-obk

d562bff

hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros Fixes rust-lang#50050

Mark-Simulacrum mentioned this pull request Jun 30, 2018

Rollup of 11 pull requests #51930

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 30, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2018

kennytm mentioned this pull request Jun 30, 2018

[WIP] Swap 1.1.1.1 and 8.8.8.8. #51939

Closed

bors added a commit that referenced this pull request Jun 30, 2018

Auto merge of #51762 - petrochenkov:oh-hi-mark, r=oli-obk

bfc1ee4

hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros Fixes #50050

bors merged commit 84f1bc8 into rust-lang:master Jun 30, 2018

This was referenced Jun 30, 2018

add modifier keyword spans to hir::Visibility; improve unreachable-pub, private-no-mangle lint suggestions #51866

Merged

Remove most of PartialEq and Hash impls from AST and HIR structures #51829

Merged

2018 edition ? Kleene operator #51587

Merged

dtolnay mentioned this pull request Jul 22, 2018

Stop using TokenStream::from_str to implement syn::parse_str dtolnay/syn#444

Closed

kennytm mentioned this pull request Jul 25, 2018

"Couldn't resolve host" errors almost daily around 6–7am UTC since May 24th travis-ci/travis-ci#9696

Closed

petrochenkov mentioned this pull request Oct 18, 2018

Tracking issue for procedural macros and "hygiene 2.0" #54727

Open

petrochenkov deleted the oh-hi-mark branch June 5, 2019 16:10

petrochenkov mentioned this pull request Feb 8, 2020

Stabilize Span::mixed_site #68716

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros #51762

hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros #51762

petrochenkov commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

petrochenkov commented Jun 24, 2018

petrochenkov commented Jun 24, 2018

petrochenkov commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

bors commented Jun 24, 2018

petrochenkov commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

alexreg commented Jun 25, 2018

oli-obk commented Jun 25, 2018

kennytm commented Jun 25, 2018

bors commented Jun 25, 2018

petrochenkov commented Jun 29, 2018

bors commented Jun 29, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

rust-highfive commented Jun 30, 2018

rust-highfive commented Jun 30, 2018

kennytm commented Jun 30, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros #51762

hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros #51762

Conversation

petrochenkov commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

petrochenkov commented Jun 24, 2018

petrochenkov commented Jun 24, 2018

petrochenkov commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

bors commented Jun 24, 2018

petrochenkov commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

bors commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

rust-highfive commented Jun 24, 2018

alexreg commented Jun 25, 2018

oli-obk commented Jun 25, 2018

kennytm commented Jun 25, 2018

bors commented Jun 25, 2018

petrochenkov commented Jun 29, 2018

bors commented Jun 29, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

rust-highfive commented Jun 30, 2018

rust-highfive commented Jun 30, 2018

kennytm commented Jun 30, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018