Rollup of 11 pull requests #51930
Closed
Rollup of 11 pull requests #51930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing as emplacement syntax (`x<-1`), suggest the correct syntax for comparison against a negative value (`x< -1`).
Allows for example `os_string == "something"`
`$crate` is not resolved at def-site of a macro, but rather at "transitive def-site"
…onSapin Implement PartialEq between &str and OsString This fixes rust-lang#49854. It allows equality comparison between `OsString` values and `str` references, such as `os_string == "something"`.
hygiene: Implement transparent marks and use them for call-site hygiene in proc-macros Fixes rust-lang#50050
…xcrichton Do not allow LLVM to increase a TLS's alignment on macOS. This addresses the various TLS segfault on macOS 10.10. Fix rust-lang#51794. Fix rust-lang#51758. Fix rust-lang#50867. Fix rust-lang#48866. Fix rust-lang#46355. Fix rust-lang#44056.
…mertj Fix some doc links The futures crate CI always fails because of these intra doc links. I hope that this will fix this issue. r? @steveklabnik @cramertj Edit: I added @steveklabnik as reviewer because this PR also adjusts a link in `src/libstd/error.rs`
…akis Point to lifetime spans on lifetime errors
Update liblibc This updates the libc submodule
Require type is sized in wfcheck.check_item_type for externed DSTs, c… …loses rust-lang#36122 Continuing rust-lang#50126.
…rkor Suggest correct comparison against negative literal When parsing as emplacement syntax (`x<-1`), suggest the correct syntax for comparison against a negative value (`x< -1`). Fix rust-lang#45651.
Fix inconsequential typo in GlobalAlloc doc example
…estebank use literal span for concrete type suggestion Fixes rust-lang#51874. r? @estebank
improve the error message when `#[panic_implementation]` is missing closes rust-lang#51341 r? @nagisa cc @phil-opp
|
@bors r+ p=10 |
|
📌 Commit b7bd4aa has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit b7bd4aa with merge 5deba6bf40808d6b0fbb1d81095134b7a48002aa... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
Failing test for cargo. I suspect #51867. The test in question: |
kennytm
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #51828) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[panic_implementation]is missing #51921 (improve the error message when#[panic_implementation]is missing)Failed merges:
r? @ghost